Bump pandas-stubs from 2.3.3.260113 to 3.0.0.260204#273
Bump pandas-stubs from 2.3.3.260113 to 3.0.0.260204#273cyiallou wants to merge 2 commits intofrequenz-floss:v0.x.xfrom
Conversation
Signed-off-by: cyiallou - Costas <42914163+cyiallou@users.noreply.github.com>
Signed-off-by: cyiallou - Costas <42914163+cyiallou@users.noreply.github.com>
cyiallou
added
the
cmd:skip-release-notes
github-actions
bot
added
the
part:tooling
There was a problem hiding this comment.
Pull request overview
Updates the project’s mypy typing dependencies to use the latest pandas-stubs, and removes now-unnecessary casting in the solar maintenance data processing code to match updated pandas typing behavior.
Changes:
- Bump
pandas-stubsfrom2.3.3.260113to3.0.0.260204in thedev-mypyextra. - Remove an explicit
cast()workaround aroundSeries.diff()results inpreprocess_data().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/frequenz/lib/notebooks/solar/maintenance/data_processing.py |
Removes an explicit cast now that pandas-stubs typing better supports .diff() + .dt. |
pyproject.toml |
Updates dev-mypy to pin pandas-stubs to the newer version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| dev-mypy = [ | ||
| "mypy == 1.19.1", | ||
| "pandas-stubs == 2.3.3.260113", | ||
| "pandas-stubs == 3.0.0.260204", |
There was a problem hiding this comment.
The runtime dependency pins pandas to < 3 (see [project].dependencies), but dev-mypy now pins pandas-stubs to 3.0.0.... Please confirm this major-version mismatch is intentional and compatible; otherwise align pandas-stubs with the supported pandas major version (or update the pandas runtime pin accordingly) to avoid incorrect type-checking assumptions.
| "pandas-stubs == 3.0.0.260204", | |
| "pandas-stubs < 3", |
No description provided.