Fix asset optimization plotly#276
Merged
Mohammad-Tayyab-Frequenz merged 3 commits intofrequenz-floss:v0.x.xfrom Mar 6, 2026
Merged
Conversation
Contributor
Mohammad-Tayyab-Frequenz
commented
Mar 4, 2026
Mohammad-Tayyab-Frequenz
commented
- Refined asset optimization Plotly visuals and layout behavior for clarity and consistency.
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
There was a problem hiding this comment.
Pull request overview
This PR refines the Plotly-based visualizations used in the asset optimization reporting notebooks, improving layout/styling consistency and adjusting how certain series are rendered (notably PV/CHP stacking and monthly bar grouping).
Changes:
- Introduce a shared Plotly styling configuration (fonts, hover labels, legend layout, axis styling) and apply it across figures.
- Update the power-flow Plotly plot to stack PV on top of CHP using
stackgroup. - Fix the monthly aggregation Plotly plot so bars group correctly by month.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/frequenz/lib/notebooks/reporting/asset_optimization/viz_plotly.py |
Updates Plotly layout defaults, legend behavior, PV/CHP stacking, subplot spacing, and monthly bar grouping. |
RELEASE_NOTES.md |
Adds release notes entries describing the Plotly visualization refinements and monthly grouping fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Mohammad Tayyab <Mohammad.Tayyab@neustrom.de>
Mohammad-Tayyab-Frequenz
force-pushed
the
fix-asset-optimization-plotly
branch
from
d4aea6d to
8d50b3c
Compare
cwasicki
approved these changes
Mar 6, 2026
Contributor
cwasicki
left a comment
cwasicki
left a comment
There was a problem hiding this comment.
If the picture above reflects the version of this PR, charge and discharge colors need to be more opaque. But I can also fix it subsequently.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.