Alternative version of python-ly conversion#138
Open
bryantgeorge wants to merge 222 commits intofrescobaldi:masterfrom
Open
Alternative version of python-ly conversion#138bryantgeorge wants to merge 222 commits intofrescobaldi:masterfrom
bryantgeorge wants to merge 222 commits intofrescobaldi:masterfrom
Conversation
Add stanzas to first voice See merge request bgeorge/python-ly!1
Resolve "Fix tests" See merge request bgeorge/python-ly!2
…ic-placement-fix-issues
…-pickup-measure-notes-timing
Resolve "Lyric Placement: fix issues" See merge request bgeorge/python-ly!6
Resolve "Measure Barlines: Use special barlines to mark phrase breaks." See merge request bgeorge/python-ly!5
Resolve "Fix Pickup Measure notes timing" See merge request bgeorge/python-ly!3
…o 'stable' Resolve "Last measures and last note lengths inconsistent" See merge request bgeorge/python-ly!8
This is because I merged into 9 instead of stable
Resolve "Fix bug caused by empty alto part" Closes frescobaldi#44 See merge request bgeorge/python-ly!51
Resolve "Support subtitles" Closes frescobaldi#46 See merge request bgeorge/python-ly!53
Resolve "Support multiple lyrics on same note" Closes frescobaldi#43 See merge request bgeorge/python-ly!50
Resolve "Support breath marks" Closes frescobaldi#45 See merge request bgeorge/python-ly!52
Resolve "Support manual measure length set" Closes frescobaldi#42 See merge request bgeorge/python-ly!55
Resolve "Handle ties from chords" Closes frescobaldi#47 See merge request bgeorge/python-ly!54
Resolve "Support italic lyrics" Closes frescobaldi#49 See merge request bgeorge/python-ly!57
# Conflicts: # ly/musicxml/lymus2musxml.py
Resolve "Fix lyric error reporting bug" Closes frescobaldi#50 See merge request bgeorge/python-ly!58
Collaborator
|
Wow, this is very nice! Thanks! My first estimation is that this really needs to be incorporated into "official" python-ly. Will look further into it the coming days! |
Collaborator
|
@PeterBjuhr maybe you can also have a look with me? You wrote most of the musicxml stuff IIRC. Some changes are easy to resolve, but others need a bit more know-how. |
Collaborator
|
I totally agree! I'll take a look! |
Collaborator
|
I'm sorry! I've taken a good look at this, but I haven't worked with it for a while and I don't think I can resolve everything! @Syobnaf can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This encompasses half a year's worth of work on the lilypond to musicxml conversion script. It drastically changes how the conversion works and was branched off of
v0.9.5, so I don't exactly expect it to be merged into master, but I hope my fork'sstablebranch can serve as an alternative version of sorts in case master doesn't fit the needs of anyone.Intended features include:
\lyricsto Voice \new Lyrics \StanzaDo with this as you will.