MusicXML: support lyricsto and addlyrics#84
Open
eoma wants to merge 16 commits intofrescobaldi:masterfrom
Open
MusicXML: support lyricsto and addlyrics#84eoma wants to merge 16 commits intofrescobaldi:masterfrom
eoma wants to merge 16 commits intofrescobaldi:masterfrom
Conversation
eoma
force-pushed
the
fix-lyricsto-and-addlyrics-for-musicxml
branch
from
90d65eb to
a4e9d4d
Compare
eoma
commented
Feb 20, 2017
| slur_stopped = False | ||
|
|
||
| for slur in obj.slur: | ||
| #if slur.phrasing: |
Contributor
Author
There was a problem hiding this comment.
If #81 is merged, this block can be uncommented.
eoma
force-pushed
the
fix-lyricsto-and-addlyrics-for-musicxml
branch
from
c3781b5 to
1fe795e
Compare
Collaborator
|
@PeterBjuhr can you comment? I'd want to help, but you're the MusicXML man :-) I wait a few days and then I'll merge the pull requests :) |
This is useful when assigning lyrics to notes after the (possibly) named voice has been merged with other voices
This makes it possible to only merge lyrics with objects having the same voice_context
eoma
force-pushed
the
fix-lyricsto-and-addlyrics-for-musicxml
branch
from
1fe795e to
0f30b25
Compare
…dlyrics-for-musicxml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to support at least basic use of addlyrics and lyricsto.
It is able to assign voice correctly to lyrics, and if addlyrics is used if will assign lyrics
to the most recently (possibly implicitly) created voice. The last one (\addlyrics) is probably not quite correct
in all cases.