Skip to content

Clean up dead code and tighten CLI numeric parsing#42

Merged
freshtechbro merged 6 commits intomainfrom
codex/dead-code-dry-cleanup
Apr 28, 2026
Merged

Clean up dead code and tighten CLI numeric parsing#42
freshtechbro merged 6 commits intomainfrom
codex/dead-code-dry-cleanup

Conversation

@freshtechbro
Copy link
Copy Markdown
Owner

Summary

  • Reuse shared CLI numeric parsing with command-specific bounds and daemon-side validation.
  • Remove the stale icon generator and update asset docs to reflect current static asset ownership.
  • Narrow internal-only exports and remove stale hardcoded tool-count guidance from agent docs.

Review and fixes

  • RepoPrompt review found missing lower-bound validation, missing scroll --dy equals-form support, and stale hardcoded tool counts.
  • Fixed those findings with parser, daemon, generated-manifest, and AGENTS updates.
  • Added boundary acceptance and invalid-bound regression coverage.
  • Follow-up RepoPrompt review reported no remaining P0/P1/P2 blockers.

Test plan

  • npx vitest run tests/cli-numeric-flag-parsing.test.ts tests/cli-args.test.ts tests/daemon-commands.integration.test.ts tests/public-surface-manifest.test.ts tests/cli-help-parity.test.ts --coverage.enabled=false
  • npm run lint
  • npm run typecheck
  • npm run build
  • npm run test
  • node scripts/docs-drift-check.mjs
  • node scripts/audit-zombie-files.mjs
  • git diff --check
  • npx opendevbrowser --help
  • npx opendevbrowser help

Co-authored-by: Codex noreply@openai.com

@freshtechbro freshtechbro changed the base branch from codex/fix-launchagent-working-directory to main April 28, 2026 13:12
freshtechbro and others added 6 commits April 28, 2026 08:12
- Route CLI wrapper numeric flags through parseNumberFlag\n- Reject empty numeric values before daemon calls\n- Cover valid and invalid forwarded payloads

Co-authored-by: Codex <noreply@openai.com>
- Delete unreferenced generator with undeclared rasterization dependency\n- Clarify checked-in raster icon workflow\n- Remove nonexistent source SVG references from asset spec

Co-authored-by: Codex <noreply@openai.com>
- Keep InspireDesign handoff skills module-private\n- Keep public-surface helper types module-private\n- Preserve generated manifest and runtime contracts

Co-authored-by: Codex <noreply@openai.com>
- Enforce command-specific lower bounds in CLI and daemon numeric parsing
- Preserve signed scroll dy equals-form parsing in public-surface metadata
- Remove stale hardcoded tool counts from agent guidance
- Add parser and daemon boundary regression coverage

Co-authored-by: Codex <noreply@openai.com>
- Preserve update-cache lock ownership and cleanup failed lock metadata writes
- Tighten signed numeric CLI parsing without hiding unknown flags
- Preserve InspireDesign guardrails and stale Canvas lifecycle lease handling

Co-authored-by: Codex <noreply@openai.com>
- Keep relay identity mismatch guidance through connect cleanup
- Count only usable reference evidence as recovered fetches
- Cover code-only capture and relay mismatch regressions

Co-authored-by: Codex <noreply@openai.com>
@freshtechbro freshtechbro force-pushed the codex/dead-code-dry-cleanup branch from 8664917 to 3c9e85f Compare April 28, 2026 13:13
@freshtechbro freshtechbro merged commit f6fa41e into main Apr 28, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant