Refactor(fw-review): reorganize scripts/ into checks/ + runners/ - #46
Open
annamalai-shan wants to merge 2 commits into
Open
Refactor(fw-review): reorganize scripts/ into checks/ + runners/#46annamalai-shan wants to merge 2 commits into
annamalai-shan wants to merge 2 commits into
Conversation
…43838)
Split skills/fw-review/scripts/ by responsibility:
- checks/ — one Node CLI per script-backed rule ID (FFS-02L, FFS-04L,
FFS-05L, FF-07L, CR-05L, GN-02L, GN-08L, GN-12L)
- runners/ — shared CLI/result plumbing (common.js exporting
createRuleResult + runCli), imported by every check
Every check now imports as require('../runners/common'). No behavior,
rule ID, JSON output contract, or App Review Result format change.
Doc references updated across SKILL.md, README.md, rules/report.md,
rules/script-check-rules.md, AGENTS.md, CONTRIBUTING.md.
Verified by running each non-FDK check from the new layout against
tests/fixtures/platform3-valid — JSON contract (internal.rule_id,
passed, summary, details) and exit codes unchanged. Installer test
suite (118 tests) passes.
Co-authored-by: Cursor <cursoragent@cursor.com>
annamalai-shan
requested review from
rapchic and
shivakumar-ashwin
as code owners
June 24, 2026 09:09
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
annamalai-shan
changed the title
annamalai-shan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganize
skills/fw-review/scripts/into two purpose-specific folders so the rule audit code is separated from the run plumbing.checks/— one Node CLI per script-backed rule ID, 8 files total:external-import-sources.js(FFS-02L),https-imports.js(FFS-04L),image-resolution.js(FFS-05L),oauth-config-usage.js(FF-07L),unused-library-imports.js(CR-05L),fdk-errors-warnings.js(GN-02L),freshworks-css-only.js(GN-08L),platform-version-upgrade.js(GN-12L).runners/— shared CLI/result plumbing (runners/common.jsexportingcreateRuleResult+runCli), imported by every check asrequire('../runners/common').internal.rule_id,passed,summary,details), exit codes, FDK prerequisites, and the## App Review Resultreport format are all byte-identical.skills/fw-review/SKILL.md,skills/fw-review/README.md,skills/fw-review/rules/report.md,skills/fw-review/rules/script-check-rules.md, rootAGENTS.md, andCONTRIBUTING.md.Diff shape
15 files changed, 48 insertions, 47 deletions. Git detects all 9 moves as renames (96–100% similarity): 1× pure rename (
common.js→runners/, 100%), 8× single-line require-path edits (checks/, 96–99%).Test plan
checks/againsttests/fixtures/platform3-validand emit the exact pre-reorg JSON contract (verifiedinternal.rule_id,passed,summary,details, andprocess.exitCode).fdk-errors-warnings.js, GN-02L) is mechanically identical to the verified 7 (samerequire('../runners/common'), samerunCli(...)wrapper).cd installer && npm test→ 118/118).grepsweep: no staleskills/fw-review/scripts/reference anywhere in the repo; only~/.fw-dev-tools/scripts/(installer's.meta.jsonhelpers) andskills/shared/scripts/remain, both unrelated.SKILL.md/README.mdpaths.npx fw-dev-tools updatethat installed copies under~/.cursor/skills/fw-review/,~/.codex/skills/fw-review/,~/.fw-dev-tools/skills/fw-review/pick upchecks/+runners/cleanly.