fix: multi-issue fixes across fw-dev-tools skills - #51
Open
rapchic wants to merge 1 commit into
Open
Conversation
- Replace latest.tgz with latest-v24.tgz for FDK 10.x/Node 24 (cross-scenarios.md, macos.md) - Remove broken openai-server-mcp-tools.md references (fw-publish/SKILL.md) - Update nvm v0.39.0 → v0.40.1 for consistency (cross-scenarios.md) - Rewrite Scenario 3 from Platform 2.x downgrade to Platform 3.0 modernization (cross-scenarios.md) - Pass line numbers to createDetail calls to fix undefined output (unused-library-imports.js) - Extract duplicated walkFiles into common.js, update 5 lint scripts to import it - Expand hybrid skeleton with onTicketCreate event, lifecycle handlers, and SMI call example - Add freshservice-requested-items.md reference doc for service catalog form data
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Multi-issue fixes across fw-dev-tools skills addressing CDN URLs, broken links, stale versions, Platform 2.x removal, lint output bugs, code deduplication, skeleton expansion, and new documentation.
Changes:
cross-scenarios.md+macos.md—latest.tgz→latest-v24.tgz,v0.39.0→v0.40.1cross-scenarios.mdScenario 3 — rewritten from "Downgrade to Legacy FDK" (Platform 2.x) to "Modernize Older App to Platform 3.0"; TOC, Testing Matrix, Quick Reference updatedfw-publish/SKILL.md— removed brokenreferences/openai-server-mcp-tools.mdlinksfw-review/scripts/common.js— extracted sharedwalkFiles+IGNORED_DIRECTORIESfw-review/scripts/{unused-library-imports,external-import-sources,freshworks-css-only,https-imports,oauth-config-usage}.js— deduplicatedwalkFilesvia common import; fixedundefinedline number in unused-library-importshybrid-skeleton/— expanded manifest with events, server with multi-handler SMI pattern, app.js withclient.request.invoke()fw-app-dev/references/freshservice-requested-items.md— new reference doc forrequested_itemsAPIType of change
SKILL.md, command file, rule file).claude-plugin,.cursor-plugin,.codex-plugin,skills/*/.cursor-plugin)installer/)tests/,installer/tests/)Test checklist
Static tests (required for all PRs)
If
installer/changed:N/A — installer not modified.
LLM evals (required when
SKILL.md, a command file, or.meta.template.jsonis modified)67 behavioral scenarios in
tests/skill-eval.test.js. Run in an agent session (recommended, no API key):Or with API key:
cd tests && ANTHROPIC_API_KEY=sk-... npm run evaltests/skill-eval.test.js(andtests/run-inline-eval.mjsif adding doc-regression checks)tests/eval-report.htmlbelow (or linked in PR description)Repo hygiene (when applicable)
AGENTS.mdrules/commands inventory updated (ifskills/*/rules/orskills/*/commands/changed)tests/TESTING.mdscenario table updated (if eval scenarios added/renamed)docs/engine-matrix.mdupdated (iffw-setuptoolchain pins changed)node scripts/bump-version.mjsrun after rootpackage.jsonversion bump (syncs plugin manifests +SKILL.md)Security
npm audit --audit-level=highpasses ininstaller/andtests/Not applicable
installer/— installer test checklist skippedCI (runs on PR automatically)
tests/npm testinstaller/npm test(Node 24)installer/+tests/lockfilesLLM evals and
tests/e2e.share local / agent session only — not in CI.Eval report