Skip to content

fix: React migrate path remapping, UI smoke test, and skill routing - #56

Merged
shivakumar-ashwin merged 2 commits into
mainfrom
test-fix
Jul 30, 2026
Merged

fix: React migrate path remapping, UI smoke test, and skill routing#56
shivakumar-ashwin merged 2 commits into
mainfrom
test-fix

Conversation

@aswin-shakthic

@aswin-shakthic aswin-shakthic commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up fixes from React Meta (MP-44662) manual testing — addresses migrate UI failures and unclear skill handoff for review/publish.

Changes:

  • /fdk-react-migrate — require /app/... route remapping, multi-location HTML checks, and mandatory fdk run UI smoke test before marking migrate complete
  • js-to-react-migration-checklist.md — same migrate gates
  • post-generation-message.txt + SKILL.md — explicit routing: review → fw-review, pack/publish → fw-publish (not generic AI review or raw FDK docs)
  • Regex eval — new test asserting migrate docs cover path remapping + smoke test

Related: builds on PR #55 (React Meta default UI stack).

Type of change

  • Skill content (SKILL.md, command file, rule file)
  • Reference / template file
  • Plugin manifest (.claude-plugin, .cursor-plugin, .codex-plugin, skills/*/.cursor-plugin)
  • Installer (installer/)
  • Test suite (tests/, installer/tests/)
  • CI / docs / infra only

Test checklist

Installer tests (required when installer/ changed)

cd installer && npm install && npm test    # installer lifecycle tests
  • Installer tests pass locally — N/A (installer/ unchanged)

Static + regex evals (required for all PRs)

cd tests && npm install && npm test        # static + parser + regex evals — runs in CI
  • All tests pass locally — 403 pass, 0 fail, 1 skipped

LLM evals (required when SKILL.md, a command file, or .meta.template.json is modified)

See When to run which layer in tests/TESTING.md.

  • Reviewed / updated scenarios — no new LLM scenarios; regex coverage added for migrate path/smoke-test docs
  • Added new scenario(s) for any new behavioral rule or gate — deferred (doc/command tightening only)
  • LLM eval scenarios pass — not re-run for this small follow-up
  • Attached tests/all-tests-report.html

Repo hygiene (when applicable)

  • AGENTS.md — N/A (no rules/commands inventory change)
  • tests/TESTING.md — N/A (no scenario count change)
  • docs/engine-matrix.md — N/A
  • node scripts/bump-version.mjs — N/A

Security

  • No secrets, tokens, or real credentials in the diff
  • No dependency changes — audit N/A

Not applicable

  • This PR does not modify skills, commands, or templates — LLM eval checklist skipped
  • This PR does not change installer/installer test checklist skipped
  • This PR does not add or change dependencies — audit checklist skipped

CI (runs on PR automatically)

Check What
Static + regex eval tests tests/npm test
Installer tests installer/npm test (Node 24)
Dependency review New deps — high/critical CVEs blocked
npm audit installer/ + tests/ lockfiles
Secret scan gitleaks (full git history)
CodeQL Org-level (if enabled)

LLM evals and tests/e2e/e2e.sh are local / agent session only — not in CI.


Eval report

Regex eval only for this PR (+1 test: fdk-react-migrate requires route remapping and fdk run smoke test). Full LLM eval not re-run.

@github-actions

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@aswin-shakthic aswin-shakthic changed the title fix: fix for failing test cases fix: React migrate path remapping, UI smoke test, and skill routing Jul 29, 2026
Comment thread skills/fw-app-dev/commands/fdk-react-migrate.md
Step 7b covers fdk run UI verification; Step 8 again holds meta-init/meta-update
so agents run metrics write only after smoke test passes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@shivakumar-ashwin
shivakumar-ashwin merged commit 56a6ef9 into main Jul 30, 2026
9 checks passed
@shivakumar-ashwin shivakumar-ashwin mentioned this pull request Jul 30, 2026
5 tasks
@aswin-shakthic aswin-shakthic mentioned this pull request Jul 30, 2026
5 tasks
shivakumar-ashwin added a commit that referenced this pull request Jul 30, 2026
* chore: prepare 1.3.0 changelog

Document React Meta default UI, installer fixes, test suite restructure,
and CI/meta-init changes since v1.2.0.

Co-authored-by: Cursor <cursoragent@cursor.com>

* 1.3.0

* chore: document PR #56 in 1.3.0 changelog

Note React migrate route remapping, UI smoke test, and skill routing updates.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Ashwin Shivakumar <ashwin.shivakumar@freshworks.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants