Changed react/socket to 0.8#49
Closed
skaffille wants to merge 3 commits intofriends-of-reactphp:masterfrom
Closed
Conversation
skaffille
force-pushed
the
skaffille/react-socket-0.8
branch
from
255ca57 to
7bb1482
Compare
Author
|
I will fix the PHP 5.6 issues as soon as possible. |
skaffille
force-pushed
the
skaffille/react-socket-0.8
branch
2 times, most recently
from
98833f6 to
1444852
Compare
Changed streams and usage of timer. Adapted unit tests.
skaffille
force-pushed
the
skaffille/react-socket-0.8
branch
from
1444852 to
19400d0
Compare
Author
|
Build works for php5.6 now, as well. |
|
@skaffille I came across those failures with #48 and made some changes to |
tree dependency is not found in trusty - two options to fix: 'apt update' before installing tree, or don't install it. I chose the latter because it does not look like it is being used
I was able to somewhat replicate the activemq install issue with the ubuntu:trusty docker image, and an 'apt update' resolved it
Author
|
@brettmc Thank you, very much. Now the build completes successfully! |
adrianspacely
pushed a commit
to adrianspacely/stomp
that referenced
this pull request
Feb 11, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated dependencies to other libraries to allow usage of react/socket 0.8.11
Changed streams and usage of timer.
Adapted unit tests.