Skip to content

fix(hubspot): align getToken + getEntityDetails with current core contract #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
d-klotz merged 1 commit into from
Jun 9, 2026
+2 −2
Merged

fix(hubspot): align getToken + getEntityDetails with current core contract #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/v1-ready/hubspot/definition.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ const Definition = {
modelName: 'HubSpot',
requiredAuthMethods: {
getToken: async function (api, params) {
const code = get(params.data, 'code');
const code = get(params, 'code');

@graphite-app graphite-app Bot Jun 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing backward compatibility fallback for params.data.code. The PR description promises a fallback for older cores but the code doesn't implement it. This will break integrations using older core versions that pass params.data.code.

Fix:

const code = get(params, 'code') || get(params.data, 'code');
Suggested change
const code = get(params, 'code');
const code = get(params, 'code') || get(params.data, 'code');

Spotted by Graphite

Fix in Graphite

Is this helpful? React 👍 or 👎 to let us know.

return api.getTokenFromCode(code);
},
getEntityDetails: async function (api, callbackParams, tokenResponse, userId) {
const userDetails = await api.getUserDetails();
return {
identifiers: {externalId: String(userDetails.portalId), userId},
identifiers: {externalId: String(userDetails.portalId), user: userId},
details: {name: userDetails.hub_domain},
}
},
Expand Down
Loading