Dead code cleanup: -381 lines, fix auth bug, extract shared concern#107
Merged
Dead code cleanup: -381 lines, fix auth bug, extract shared concern#107
Conversation
Deleted (10 files): - HttpBasicAuthenticable concern (never included) - movement_demo route + orphan test (no controller existed) - PWA views (routes commented out) - content_security_policy.rb (entirely commented out) - react_server_rendering.rb (referenced non-existent asset) - blog.rake (duplicate of blog_posts.rake) - convert_images.rake (target directory doesn't exist) - ScrollbarStyles.jsx (never imported) - DebugPanel.jsx (never imported) Fixes: - BriefingsController now inherits Api::V1::BaseController (was bypassing API auth) - Extracted format_money into MoneyFormattable concern (was duplicated 3x) 109 tests, 0 failures. Rubocop clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Dead code removal and DRY extraction from codebase audit. @frogr
Deleted (10 files, -381 lines)
HttpBasicAuthenticableconcern/movement-demoroute + testcontent_security_policy.rbreact_server_rendering.rbserver_rendering.jsblog.rakeblog_posts.rakeconvert_images.rakeScrollbarStyles.jsxDebugPanel.jsxFixes
Auth bug:
BriefingsControllerwas inheriting fromApplicationControllerinstead ofApi::V1::BaseController, bypassing API authentication while living in the API namespace.DRY: Extracted
format_moneyintoMoneyFormattableconcern — was copy-pasted in 3 places (Invoice model, InvoicePdfService, InvoicesHelper).Verified
bundle exec rubocop— 208 files, 0 offensesbin/rails test— 109 tests, 0 failures