don't use style-loader in production#12
Open
bj00rn wants to merge 1 commit into
Open
Conversation
- upgrade to webpack 4 in order to use MiniCssExtractPlugin for production builds
Author
|
@fritz-c any thoughts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style-loaderforces inline<style />tags upon users of this library.This is a security problem since it prevents the application of sane CSP configuration. ( requires
style-src 'unsafe-inline';)Webpack 4 has the superawesome
MinCssExtractPluginthis purpose, this enables users of this library to use the webpack plugin pipline (html-webpack-pluginet al.) to decide if the wan't to inline the library styles or use them in a bundle.The PR includes
MinCssExtractPluginplugin in production builds- upgrade to Webpack 4 in order to use
MiniCssExtractPlugin