fix(tui): restore Eve's blink on the full-color portrait#46
Open
fruwe wants to merge 1 commit into
Open
Conversation
The pixel-art hero redesign replaced the old portrait but left _eve_portrait() pinned to the open-eyed art, so the 15s blink timer fired with no visible effect. Derive closed-eyes frames from the open-eyed art via a grid-level _close_eyes() helper: it explodes each markup line into per-column cells, repaints the dark eye clusters to nearby skin, and draws a soft lid line across each eye's middle row so a blink reads as eyes shutting rather than vanishing. Both the full and small figures now blink, with eye boxes bounded to avoid the hairline above the left eye.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pixel-art hero redesign (#45) replaced the old portrait but left
_eve_portrait()pinned to the open-eyed art, so the 15s blink timer fired with no visible effect — Eve stopped blinking.This derives closed-eyes frames from the open-eyed art via a grid-level
_close_eyes()helper: it explodes each markup line into per-column cells, repaints the dark eye clusters to nearby skin, and draws a soft lid line across each eye's middle row so a blink reads as eyes shutting rather than vanishing. Both the full and small figures blink again, with the eye boxes bounded to avoid the hairline above the left eye.Notes
█, so there is no terminal-font dependency.Test
Targeted TUI test selection green (79 passed); full
make testnot run.