6 targeted structural fixes: dead code removal, precedence bug, and routing consistency

[Copilot]

Structural audit of the codebase surfaced 6 concrete issues fixed here, plus 4 larger architectural proposals documented in the PR thread.

Bug fix

Operator precedence in ElementMarkupRenderer (two locations)

PHP's . binds tighter than ?:, so the original expression silently evaluated as:

// Before — ternary applied to the concatenated string, not the condition
throw new \InvalidArgumentException("Unsupported type " . ($element && \is_object($element)) ? \get_class($element) : gettype($element));

// After
throw new \InvalidArgumentException("Unsupported type " . (($element && \is_object($element)) ? \get_class($element) : gettype($element)));

Dead code removal

• ArrayUtil::hasSet() — self-documented as @deprecated with a known behavioral bug (writes the key, not the value); zero callers.
• VendorSpecific::getConfiguration() — @deprecated, attributed to WmcParser110 which no longer exists anywhere in the repo; zero callers.
• @Annotation tag on FOM\ManagerBundle\Configuration\Route — Doctrine Annotations v1 artefact; the class already declares #[\Attribute].
• @see \Mapbender\CoreBundle\Component\Element::render in LegacyView — references a class/method that no longer exists.

Consistency

ManagerRoute alias in FOM UserBundle controllers — GroupController and PermissionController imported FOM\ManagerBundle\Configuration\Route without alias and used it as #[Route(...)], indistinguishable from the standard Symfony route at a glance. Aligned with UserController's existing as ManagerRoute alias.

Documented-only proposals (too large for this PR)

• Split monolithic CoreBundle (~500 files) into domain-focused sub-bundles
• Migrate 13 services.xml files to PHP autowiring or YAML
• Establish per-bundle unit test coverage (currently 6 test files total)
• Replace UserControllerBase/ApplicationControllerBase inheritance with composition

Original prompt

Again. I am in the repo frwg/mapbender and I want you to work in this, the branch develop-local that you just mentioned is in a different repo that I dont want to investigate

[Chronological Review: The conversation began with the user requesting an analysis of a repository in the cloud to identify structural issues worth refactoring. The user then canceled this request and specified that they wanted to focus on the repository "frwg/mapbender" in the "develop-local" branch, indicating a shift in focus away from the previous repository.]

[Intent Mapping:

1. "Look at the repository in the cloud and make 10 proposals where you detect structurally bad things that you think are worth to refactor" - User wants a structural analysis of a cloud repository.
2. "Cancel: 'Delegate to cloud agent'" - User cancels the previous request.
3. "Again. I am in the repo frwg/mapbender and I want you to work in this, the branch develop-local that you just mentioned is in a different repo that I dont want to investigate" - User clarifies their focus on a specific repository and branch.]

[Technical Inventory:

• Repository: frwg/mapbender
• Branch: develop-local
• File: /home/frauch/Softwareentwicklung/mapbender-starter/application/composer.json]

[Code Archaeology: No specific code changes or files were discussed in detail, but the focus is on the composer.json file within the context of the frwg/mapbender repository.]

[Progress Assessment: User has shifted focus from a cloud repository to a specific local repository and branch. No tasks have been completed yet, as the user is still in the process of defining the scope of work.]

[Context Validation: The user is now focused on the frwg/mapbender repository and has specified the branch they want to work on. This context is crucial for any further actions.]

[Recent Commands Analysis:

• Last Agent Commands: The user requested to analyze a repository and then canceled that request. They subsequently clarified their focus on the frwg/mapbender repository.
• Tool Results Summary: No tool results were generated as the user canceled the initial request and redirected focus to a different repository.
• Pre-Summary State: The agent was preparing to analyze the cloud repository when the user canceled the request and specified a new focus.
• Operation Context: The user is looking to identify structural issues in the frwg/mapbender repository, specifically in the develop-local branch.]

1. Conversation Overview: - Primary Objectives: 1. "Look at the repository in the cloud and make 10 proposals where you detect structurally bad things that you think are worth to refactor." 2. "Again. I am in the repo frwg/mapbender and I want you to work in this, the branch develop-local that you just mentioned is in a different repo that I dont want to investigate." - Session Context: The user initially requested a structural analysis of a cloud repository but later redirected focus to a specific local repository and branch. - User Intent Evolution: The user shifted from a broader analysis of a cloud repository to a targeted analysis of the frwg/mapbender repository.

2. Technical Foundation:

• Repository: frwg/mapbender
• Branch: develop-local
• File: /home/frauch/Softwareentwicklung/mapbender-starter/application/composer.json

3. Codebase Status:

• File Name: composer.json
• Purpose: This file is crucial for managing dependencies in the PHP project.
• Current State: No specific modifications discussed yet.
• Key Code Segments: Not applicable at this stage.
• Dependencies: This file relates to the overall project setup and dependency management.

4. Problem Resolution:

• Issues Encountered: No specific technical problems have been identified yet.
• Solutions Implemented: None, as the user is still defining the scope of work.
• Debugging Context: No ongoing troubleshooting efforts have been mentioned.
• Lessons Learned: No insights have been documented yet.

5. Progress Tracking:

• Completed Tasks: None yet, as the user is still in the process of defining the work.
• Partially Complete Work: The user has clarified their focus on the frwg/mapbender repository.
• Validated Outcomes: No features or code have been confirmed working through testing.

6. Active Work State:

• Current Focus: The user is focused on analyzing the frwg/mapbender repository in the develop-local branch.
• Recent Context: The user canceled the initial request for cloud analysis and specified their current repository.
• Working Code: No specific code snippets have been discussed recently.
• Immediate Context: The user is preparing to identify structural issues in the specified repository.

7. Recent Operations:

• Last Agent Commands: User requested an analysis of a cloud repository, canceled that request, and specified a new focus on the frwg/mapbender repository.
• Tool Results Summary: No tool results were generated due to the cancellation of the initial request.
• Pre-Summary State: The a...

Created from VS Code.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.