refactor(macrobench): share helm args and update cloudbuild config#940
Merged
Merged
Conversation
zhixiangli
commented
Jun 29, 2026
Collaborator
- Extract shared helm arguments to shared_workload_helm_args in lib.sh
- Update run_workload.sh and seed_checkpoint.sh to use shared helm args
- Update ingest.sql to support non-UUID build IDs
- Pass additional parameters (_IMAGE, _RANKS_PER_NODE, _MACHINE_TYPE) in macrobenchmarks-cloudbuild.yaml
- Extract shared helm arguments to shared_workload_helm_args in lib.sh - Update run_workload.sh and seed_checkpoint.sh to use shared helm args - Update ingest.sql to support non-UUID build IDs - Pass additional parameters (_IMAGE, _RANKS_PER_NODE, _MACHINE_TYPE) in macrobenchmarks-cloudbuild.yaml
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Helm installation scripts for macrobenchmarks by extracting shared Helm arguments into a helper function, reducing duplication across scripts. It also updates the SQL query in ingest.sql to support non-UUID build IDs and adds missing parameters to the Cloud Build configuration. Feedback is provided regarding a potential shell parsing issue with backslash escaping in lib.sh.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #940 +/- ##
=======================================
Coverage 89.68% 89.68%
=======================================
Files 16 16
Lines 3579 3579
=======================================
Hits 3210 3210
Misses 369 369 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Yonghui-Lee
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.