Skip to content

refactor(macrobench): share helm args and update cloudbuild config#940

Merged
zhixiangli merged 1 commit into
fsspec:mainfrom
zhixiangli:bugfix-macrobench-cloudbuild
Jun 29, 2026
Merged

refactor(macrobench): share helm args and update cloudbuild config#940
zhixiangli merged 1 commit into
fsspec:mainfrom
zhixiangli:bugfix-macrobench-cloudbuild

Conversation

@zhixiangli

Copy link
Copy Markdown
Collaborator
  • Extract shared helm arguments to shared_workload_helm_args in lib.sh
  • Update run_workload.sh and seed_checkpoint.sh to use shared helm args
  • Update ingest.sql to support non-UUID build IDs
  • Pass additional parameters (_IMAGE, _RANKS_PER_NODE, _MACHINE_TYPE) in macrobenchmarks-cloudbuild.yaml

- Extract shared helm arguments to shared_workload_helm_args in lib.sh
- Update run_workload.sh and seed_checkpoint.sh to use shared helm args
- Update ingest.sql to support non-UUID build IDs
- Pass additional parameters (_IMAGE, _RANKS_PER_NODE, _MACHINE_TYPE) in macrobenchmarks-cloudbuild.yaml
@zhixiangli zhixiangli marked this pull request as ready for review June 29, 2026 06:02

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Helm installation scripts for macrobenchmarks by extracting shared Helm arguments into a helper function, reducing duplication across scripts. It also updates the SQL query in ingest.sql to support non-UUID build IDs and adds missing parameters to the Cloud Build configuration. Feedback is provided regarding a potential shell parsing issue with backslash escaping in lib.sh.

Comment thread cloudbuild/macrobenchmarks/scripts/lib.sh
@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (a38076b) to head (3b83574).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   89.68%   89.68%           
=======================================
  Files          16       16           
  Lines        3579     3579           
=======================================
  Hits         3210     3210           
  Misses        369      369           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zhixiangli zhixiangli merged commit 7e658e0 into fsspec:main Jun 29, 2026
10 checks passed
@zhixiangli zhixiangli deleted the bugfix-macrobench-cloudbuild branch June 29, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants