Fix Tool configuration file dialog when selecting XRNS2XMOD Shell exe#2
Open
nrichards wants to merge 1 commit intofstarred:masterfrom
Open
Fix Tool configuration file dialog when selecting XRNS2XMOD Shell exe#2nrichards wants to merge 1 commit intofstarred:masterfrom
nrichards wants to merge 1 commit intofstarred:masterfrom
Conversation
- Use file extension instead of full filename to configure dialog - Seen on MacOS 10.13.6 / Renoise 3.1.1 64b - Affirmed by Renoise API documentation http://files.renoise.com/xrnx/documentation/Renoise.Application.API.lua.html ``` Opens a modal dialog to query a filename and path to read from a file. The given extension(s) should be something like {"wav", "aiff" or "*" (any file) } renoise.app():prompt_for_filename_to_read({file_extensions}, dialog_title) -> [filename or empty string] ``` - Make more explicit the configuration file dialog's textual instructions
Owner
|
@nrichards thanks for the update, it's ok for updating the dialog title, however I have still some doubts about generalizing the exe name to a .exe because a new tool's user may have have some mistake on which exe to locate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
instructions