Replace html-minifier with html-minifier-terser to remove dependency on uglify and support ES6 and newer#10
Merged
chunkai1312 merged 2 commits intofugle-dev:nextfrom Jan 29, 2025
Conversation
Contributor
mellster2012
commented
Jan 29, 2025
mellster2012
commented
- See: [Documentation] Difference between html-minifier-terser and original html-minifier terser/html-minifier-terser#37 and Cannot find module '../lib/utils.js' in esbuild mjmlio/mjml#2132
- Also adds a public method to get the plotted html as a minified string (e.g. to upload to S3)
…on uglify and support ES6 and newer
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## next #10 +/- ##
=======================================
Coverage ? 62.66%
=======================================
Files ? 19
Lines ? 2199
Branches ? 594
=======================================
Hits ? 1378
Misses ? 821
Partials ? 0 ☔ View full report in Codecov by Sentry. |
chunkai1312
reviewed
Jan 29, 2025
package.json
Outdated
| { | ||
| "name": "@fugle/backtest", | ||
| "version": "1.0.0-beta.1", | ||
| "version": "1.0.0-beta.0", |
Contributor
There was a problem hiding this comment.
Please update to the latest version.
Contributor
Author
There was a problem hiding this comment.
Done - thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.