refactor: drop the Windows PowerShell launcher in favor of Git Bash#186
Open
lucianlamp wants to merge 1 commit into
Open
refactor: drop the Windows PowerShell launcher in favor of Git Bash#186lucianlamp wants to merge 1 commit into
lucianlamp wants to merge 1 commit into
Conversation
The PowerShell launcher (scripts/windows/agmsg.ps1 + install-agmsg.ps1) was a thin shim that located Git Bash and forwarded to the Bash scripts. Codex on Windows runs commands through PowerShell, so agents can call the scripts directly via Git Bash (`bash -lc 'scripts/*.sh'`), and delivery hooks are already wrapped for Git Bash by windows_wrap() in delivery.sh. The separate PowerShell reimplementation is now redundant. Removed: - scripts/windows/agmsg.ps1, scripts/windows/install-agmsg.ps1 - docs/windows.md - tests/smoke_windows_powershell.ps1, tests/test_windows_powershell.bats - the PowerShell launcher install step in install.sh - the README "Native Windows / PowerShell" section (replaced with a Git Bash note) Kept (general Windows support): the Bash dispatcher (dispatch.sh), the delivery hook Git Bash wrapping (delivery.sh windows_wrap), the sqlite3 shim, and install.sh's legacy-helper cleanup. BREAKING CHANGE: the `agmsg` PowerShell command is no longer installed. On Windows, call the scripts through Git Bash, e.g. `bash -lc 'scripts/whoami.sh "$(pwd)" codex'`. If a bare `bash` resolves to the WSL shim, pin Git Bash in your PowerShell profile: Set-Alias bash 'C:\Program Files\Git\bin\bash.exe'. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XpJ8VvSV1hNdJWy875V5tm
Contributor
Author
|
CI note: the targeted checks for this PR are green, including The only non-green check is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commandWindowswrapping, and legacy helper cleanupWhy
agmsg is implemented as Bash scripts. On Windows, Claude Code naturally works with Bash/Git Bash for these calls, but native Windows Codex commands and hooks often start from PowerShell. PowerShell cannot execute bare
.shfiles, and a barebashcan resolve to the WSL shim (WindowsApps\bash.exe), which uses a separate$HOMEand can create or read a different SQLite database.This keeps the Windows story best-effort but less ambiguous: run agmsg through Git Bash, and tell users to pin Git Bash in their PowerShell profile when needed.
Test Plan
bash -lc 'bash -n install.sh scripts/*.sh'bats tests/test_install.bats- not run locally becausebatsis not installed in this environment