Skip to content

test(windows): read settings files via cygpath in sqlite readfile() (#184) #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fujibee merged 1 commit into from
Jun 22, 2026
Merged

test(windows): read settings files via cygpath in sqlite readfile() (#184) #187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions tests/test_delivery.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ agmsg_entries() {
local event="$2"
if [ ! -f "$file" ]; then echo 0; return; fi
sqlite_mem "
SELECT count(*) FROM json_each(json_extract(readfile('$file'), '\$.hooks.$event')) AS s
SELECT count(*) FROM json_each(json_extract(readfile('$(rf "$file")'), '\$.hooks.$event')) AS s
WHERE EXISTS (
SELECT 1 FROM json_each(json_extract(s.value, '\$.hooks')) AS h
WHERE instr(json_extract(h.value, '\$.command'), 'agmsg') > 0
Expand Down Expand Up @@ -80,16 +80,16 @@ settings_file() {
bash "$SCRIPTS/delivery.sh" set monitor claude-code "$TEST_PROJECT"
bash "$SCRIPTS/delivery.sh" set monitor claude-code "$TEST_PROJECT"
local n
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.hooks.SessionStart'));")
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.hooks.SessionStart'));")
[ "$n" = "1" ]
}

@test "delivery set both: idempotent across repeats" {
bash "$SCRIPTS/delivery.sh" set both claude-code "$TEST_PROJECT"
bash "$SCRIPTS/delivery.sh" set both claude-code "$TEST_PROJECT"
local s t
s=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.hooks.SessionStart'));")
t=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.hooks.Stop'));")
s=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.hooks.SessionStart'));")
t=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.hooks.Stop'));")
[ "$s" = "1" ]
[ "$t" = "1" ]
}
Expand Down Expand Up @@ -124,7 +124,7 @@ settings_file() {
echo '{"permissions":{"allow":["Bash"]}}' > "$(settings_file)"
bash "$SCRIPTS/delivery.sh" set monitor claude-code "$TEST_PROJECT"
local p
p=$(sqlite_mem "SELECT json_extract(readfile('$(settings_file)'), '\$.permissions.allow[0]');")
p=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$(settings_file)")'), '\$.permissions.allow[0]');")
[ "$p" = "Bash" ]
}

Expand All @@ -141,7 +141,7 @@ settings_file() {

# Still valid JSON, the multibyte value survived byte-for-byte, hook landed.
local valid
valid=$(sqlite_mem "SELECT json_valid(readfile('$(settings_file)'));")
valid=$(sqlite_mem "SELECT json_valid(readfile('$(rf "$(settings_file)")'));")
[ "$valid" = "1" ]
grep -q "日本語のメモ" "$(settings_file)"
grep -q "session-start.sh" "$(settings_file)"
Expand Down Expand Up @@ -360,7 +360,7 @@ has_session_end() {
bash "$SCRIPTS/delivery.sh" set monitor claude-code "$TEST_PROJECT"
bash "$SCRIPTS/delivery.sh" set monitor claude-code "$TEST_PROJECT"
local n
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.hooks.SessionEnd'));")
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.hooks.SessionEnd'));")
[ "$n" = "1" ]
}

Expand Down Expand Up @@ -568,10 +568,10 @@ EOF
[ -f "$hook_file" ]
# JSON sanity: version=1, Stop entry references check-inbox.sh
local v
v=$(sqlite_mem "SELECT json_extract(readfile('$hook_file'), '\$.version');")
v=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$hook_file")'), '\$.version');")
[ "$v" = "1" ]
local cmd
cmd=$(sqlite_mem "SELECT json_extract(readfile('$hook_file'), '\$.hooks.Stop[0].bash');")
cmd=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$hook_file")'), '\$.hooks.Stop[0].bash');")
[[ "$cmd" =~ "check-inbox.sh" ]]
[[ "$cmd" =~ "copilot" ]]
}
Expand Down Expand Up @@ -602,7 +602,7 @@ EOF
[ "$status" -ne 0 ]
[ -f "$TEST_PROJECT/.github/hooks/agmsg.json" ]
local n
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$TEST_PROJECT/.github/hooks/agmsg.json'), '\$.hooks.Stop'));")
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$TEST_PROJECT/.github/hooks/agmsg.json")'), '\$.hooks.Stop'));")
[ "$n" = "1" ]
}

Expand Down Expand Up @@ -633,7 +633,7 @@ EOF
bash "$SCRIPTS/delivery.sh" set turn copilot "$TEST_PROJECT"
bash "$SCRIPTS/delivery.sh" set turn copilot "$TEST_PROJECT"
local n
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$TEST_PROJECT/.github/hooks/agmsg.json'), '\$.hooks.Stop'));")
n=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$TEST_PROJECT/.github/hooks/agmsg.json")'), '\$.hooks.Stop'));")
[ "$n" = "1" ]
}

Expand Down Expand Up @@ -911,7 +911,7 @@ JSON
local hook_file="$TEST_PROJECT/.codex/hooks.json"
[ -f "$hook_file" ]
local cw
cw=$(sqlite_mem "SELECT json_extract(readfile('$hook_file'), '\$.hooks.Stop[0].hooks[0].commandWindows');")
cw=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$hook_file")'), '\$.hooks.Stop[0].hooks[0].commandWindows');")
[ -n "$cw" ]
[[ "$cw" == *"Program Files\\Git\\bin\\bash.exe"* ]]
[[ "$cw" == *"GIT_BASH"* ]]
Expand All @@ -926,7 +926,7 @@ JSON
local hook_file="$TEST_PROJECT/.claude/settings.local.json"
[ -f "$hook_file" ]
local cw
cw=$(sqlite_mem "SELECT json_extract(readfile('$hook_file'), '\$.hooks.Stop[0].hooks[0].commandWindows');")
cw=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$hook_file")'), '\$.hooks.Stop[0].hooks[0].commandWindows');")
[ -z "$cw" ]
}

Expand Down Expand Up @@ -1015,7 +1015,7 @@ skip_if_no_special_fs() {
JSON
run bash "$SCRIPTS/delivery.sh" set monitor claude-code "$TEST_PROJECT"
[ "$status" -eq 0 ]
[ "$(sqlite_mem "SELECT json_valid(readfile('$(settings_file)'));")" = "1" ]
[ "$(sqlite_mem "SELECT json_valid(readfile('$(rf "$(settings_file)")'));")" = "1" ]
has_session_start "$(settings_file)"
}

Expand Down Expand Up @@ -1053,9 +1053,9 @@ JSON

# Existing user permissions must be preserved across the rewrite.
local first last allow_len
first=$(sqlite_mem "SELECT json_extract(readfile('$(settings_file)'), '\$.permissions.allow[0]');")
last=$(sqlite_mem "SELECT json_extract(readfile('$(settings_file)'), '\$.permissions.allow[599]');")
allow_len=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.permissions.allow'));")
first=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$(settings_file)")'), '\$.permissions.allow[0]');")
last=$(sqlite_mem "SELECT json_extract(readfile('$(rf "$(settings_file)")'), '\$.permissions.allow[599]');")
allow_len=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.permissions.allow'));")
[ "$first" = "Bash(mkdir:/tmp/agmsg-e2big-entry-0001)" ]
[ "$last" = "Bash(mkdir:/tmp/agmsg-e2big-entry-0600)" ]
[ "$allow_len" = "600" ]
Expand All @@ -1081,7 +1081,7 @@ JSON
has_check_inbox "$(settings_file)"

local allow_len
allow_len=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.permissions.allow'));")
allow_len=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.permissions.allow'));")
[ "$allow_len" = "600" ]
}

Expand All @@ -1106,7 +1106,7 @@ JSON
local inflated
inflated=$(sqlite_mem "
SELECT json_set(
json_set(readfile('$(settings_file)'), '\$.permissions', json('{}')),
json_set(readfile('$(rf "$(settings_file)")'), '\$.permissions', json('{}')),
'\$.permissions.allow', json('$allow_json')
);
")
Expand All @@ -1116,7 +1116,7 @@ JSON
[ "$status" -eq 0 ]
! has_check_inbox "$(settings_file)"
local allow_len
allow_len=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(settings_file)'), '\$.permissions.allow'));")
allow_len=$(sqlite_mem "SELECT json_array_length(json_extract(readfile('$(rf "$(settings_file)")'), '\$.permissions.allow'));")
[ "$allow_len" = "600" ]
}

Expand Down
16 changes: 16 additions & 0 deletions tests/test_helper.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,22 @@ skip_on_windows() {
# This is the test-side mirror of scripts/lib/storage.sh's agmsg_sqlite_mem.
sqlite_mem() { sqlite3 :memory: "$@" | tr -d '\r'; }

# Resolve a file path for use inside a sqlite3 readfile('...') call in a test.
# On native Windows, sqlite3 only reads a Windows path (C:\Users\...), not a Git
# Bash POSIX path (/c/Users/... or /tmp/...): an unconverted path reads back as
# empty, so the surrounding json_extract / json_valid sees nothing and the check
# fails even though the script under test wrote a correct file. cygpath -w
# converts it; a no-op off Windows (cygpath absent). The result is then single-
# quote-escaped for the SQL string literal. Mirrors scripts/lib/storage.sh's
# agmsg_sql_readfile_path — the production helper these tests are validating.
rf() {
local p="$1"
if command -v cygpath >/dev/null 2>&1; then
p="$(cygpath -w "$p" 2>/dev/null || printf '%s' "$p")"
fi
printf '%s' "$p" | sed "s/'/''/g"
}

# Pin a fake-owned session_id under the given run/ directory so the lock
# liveness check (which runs `kill -0` on cc-instance.<pid>) considers
# <sid> alive for the duration of the bats process.
Expand Down
2 changes: 1 addition & 1 deletion tests/test_team.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ teardown() {
[[ "$output" =~ "Renamed team oldteam → newteam" ]]
[ ! -d "$TEST_SKILL_DIR/teams/oldteam" ]
[ -f "$TEST_SKILL_DIR/teams/newteam/config.json" ]
run sqlite_mem "SELECT json_extract(readfile('$TEST_SKILL_DIR/teams/newteam/config.json'), '\$.name');"
run sqlite_mem "SELECT json_extract(readfile('$(rf "$TEST_SKILL_DIR/teams/newteam/config.json")'), '\$.name');"
[ "$output" = "newteam" ]
}

Expand Down
Loading