Skip to content

Document how to include Sketches in Reports#38

Closed
nehilor wants to merge 4 commits intov2from
feature/FLCRM-19499-copy-all-ref-files
Closed

Document how to include Sketches in Reports#38
nehilor wants to merge 4 commits intov2from
feature/FLCRM-19499-copy-all-ref-files

Conversation

@nehilor
Copy link
Contributor

@nehilor nehilor commented Mar 6, 2026

Description

This PR documents the new copy_all API endpoint for copying reference files between forms, as requested in FLCRM-19499.

Changes:

  • Added AttachmentCopyAllRequest and AttachmentCopyAllResponse schemas to rest-api.json.
  • Defined the POST /v2/attachments/copy_all endpoint in rest-api.json.
  • Created a new documentation page copy-all-attachments.md details the endpoint and its current limits (100 files / form, 1GB / form).
  • Updated _order.yaml to include the new endpoint in the Attachments API documentation.

Limits:

  • 100 reference files per form.
  • 1GB total per form.

Copilot AI review requested due to automatic review settings March 6, 2026 16:42
@nehilor nehilor requested review from a team as code owners March 6, 2026 16:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documents the new POST /v2/attachments/copy_all endpoint for copying reference files between forms, adding the OpenAPI schema/operation definitions and a new Attachments docs page.

Changes:

  • Added AttachmentCopyAllRequest / AttachmentCopyAllResponse schemas to the OpenAPI spec.
  • Defined POST /v2/attachments/copy_all in reference/rest-api.json.
  • Added a new docs page and updated Attachments docs ordering to include it.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

File Description
reference/rest-api.json Adds request/response schemas and the copy_all endpoint definition.
reference/ATTACHMENTS/copy-all-attachments.md New documentation page describing the endpoint and its limits.
reference/ATTACHMENTS/_order.yaml Adds the new page to the Attachments docs navigation order.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +10256 to +10266
"parameters": [
{
"name": "X-ApiToken",
"in": "header",
"description": "API Token. Required to authenticate the request.",
"required": true,
"schema": {
"type": "string"
}
}
],
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auth header parameter name here uses X-ApiToken (and is marked required: true), but the other Attachments endpoints in this same spec use x-apitoken and omit required. To keep the generated docs consistent, align this endpoint with the existing Attachments header parameter convention (or omit the explicit header parameter entirely and rely on the global ApiToken security scheme).

Copilot uses AI. Check for mistakes.
"$ref": "#/components/schemas/AttachmentCopyAllResponse"
}
}
}
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new endpoint only documents a 200 response. Other Attachments endpoints also document 401 Unauthorized; adding a 401 response here would make the OpenAPI spec more complete and consistent for API consumers.

Suggested change
}
}
},
"401": {
"description": "401",
"content": {
"application/json": {
"examples": {
"Result": {
"value": "{\n \"error\": \"Unauthorized\"\n}"
}
},
"schema": {
"type": "object",
"properties": {
"error": {
"type": "string",
"example": "Unauthorized"
}
}
}
}
}

Copilot uses AI. Check for mistakes.
Comment on lines +11 to +15
title: ""
description: ""
robots: noindex
next:
description: ""
Copy link

Copilot AI Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontmatter in other Attachments docs uses single quotes for empty strings (e.g., title: ''), but this page uses double quotes (""). Consider switching to single quotes for consistency with the rest of the docs and to avoid potential formatting/linting differences.

Suggested change
title: ""
description: ""
robots: noindex
next:
description: ""
title: ''
description: ''
robots: noindex
next:
description: ''

Copilot uses AI. Check for mistakes.
@nehilor nehilor changed the title Document the copy_all API endpoint for reference files Document how to include Sketches in Reports Mar 9, 2026
@nehilor nehilor closed this Mar 9, 2026
@nehilor nehilor deleted the feature/FLCRM-19499-copy-all-ref-files branch March 9, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants