fix(#45): tighten review verdict criteria for medium findings#49
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#45): tighten review verdict criteria for medium findings#49fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Replace the subjective "multiple medium-severity findings which could affect the intended outcome" criterion with an objective rule: two or more medium findings, at least one identifying a functional bug, require request-changes. Add a self-consistency check to the pr-review synthesis step: if the summary text states findings should be addressed before merge, the verdict must be request-changes, not comment. Update comment-only criteria to clarify it applies only to stylistic, advisory, or process-related medium findings. Changes: - agents/review.md: Outcome section verdict criteria - skills/pr-review/SKILL.md: Step 6f verdict logic and self-consistency check Note: pre-commit could not run (shellcheck-py failed to install due to sandbox network restrictions). Secret scan passed. Closes #45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the subjective "multiple medium-severity findings which could affect the intended outcome" criterion with an objective rule: two or more medium findings, at least one identifying a functional bug, require request-changes.
Add a self-consistency check to the pr-review synthesis step: if the summary text states findings should be addressed before merge, the verdict must be request-changes, not comment.
Update comment-only criteria to clarify it applies only to stylistic, advisory, or process-related medium findings.
Changes:
self-consistency check
Note: pre-commit could not run (shellcheck-py failed to install due to sandbox network restrictions). Secret scan passed.
Closes #45
Post-script verification
agent/45-fix-review-verdict-consistency)2540ede96537b32447321564bec60226efca120e..HEAD)