Skip to content

chore: gitignore superpowers plan files#3550

Merged
ralphbean merged 1 commit into
mainfrom
chore/gitignore-superpowers-plans
Jul 8, 2026
Merged

chore: gitignore superpowers plan files#3550
ralphbean merged 1 commit into
mainfrom
chore/gitignore-superpowers-plans

Conversation

@ralphbean

Copy link
Copy Markdown
Member

Summary

  • Add docs/superpowers/plans/*.md to .gitignore — these are local working documents generated by the planning skill, not project artifacts
  • git rm all 10 tracked plan files
  • Remove two dangling links in spec docs that referenced a deleted plan file

Test plan

  • Pre-commit hooks pass (link linter, end-of-file fixer, etc.)

🤖 Generated with Claude Code

Two spec docs linked to the plan file that was just git-rm'd.
Remove the dangling references so the link linter passes.

Assisted-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Ralph Bean <rbean@redhat.com>
@ralphbean ralphbean requested a review from a team as a code owner July 8, 2026 12:54
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 8, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 12:55 PM UTC · Completed 1:05 PM UTC
Commit: 5c864d1 · View workflow run →

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Site preview

Preview: https://2d488759-site.fullsend-ai.workers.dev

Commit: 5c864d16a3ac05ed4961c7a0096dec1500b1331e

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Ignore superpowers plan drafts and remove broken spec links

⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Ignore docs/superpowers/plans/*.md since these are local planning outputs, not artifacts.
• Remove previously-tracked plan files from the repository history going forward.
• Fix spec docs by deleting dangling links to the removed plan document.
Diagram

graph TD
  Dev["Developer"] --> Git["Git tracking"] --> GI[".gitignore"] --> Plans["plans/*.md"]
  Git --> Specs["spec docs"] --> Links["plan links removed"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Use per-user ignore (e.g., .git/info/exclude or global gitignore)
  • ➕ Avoids imposing ignore rules on contributors who may want to version plans
  • ➖ Doesn’t prevent accidental commits by others
  • ➖ Harder to enforce consistently; CI/link linters may still break if committed
2. Move plan outputs under an already-ignored working directory
  • ➕ Keeps repository ignore rules simpler
  • ➕ Makes “generated/local-only” intent obvious in the filesystem
  • ➖ Requires updating the planning skill/output path conventions
  • ➖ Existing tooling/docs may assume current location

Recommendation: Keep the repo-level .gitignore rule: it reliably prevents accidental commits of planning outputs across all contributors, and pairing it with link cleanup keeps documentation tooling (link lint) green.

Files changed (3) +1 / -2

Documentation (2) +1 / -2
2026-04-06-fullsend-admin-spa-design.mdRemove reference to deleted implementation plan file +1/-1

Remove reference to deleted implementation plan file

• Drops a link to the now-removed admin SPA plan document while keeping the verification note content.

docs/superpowers/specs/2026-04-06-fullsend-admin-spa-design.md

2026-04-21-fullsend-admin-spa-ux-design.mdRemove broken related-docs link to deleted plan file +0/-1

Remove broken related-docs link to deleted plan file

• Deletes a dangling related-document link pointing into '../plans/', preventing link-linter failures.

docs/superpowers/specs/2026-04-21-fullsend-admin-spa-ux-design.md

Other (1)
.gitignoreIgnore superpowers plan draft markdown files +0/-0

Ignore superpowers plan draft markdown files

• Adds an ignore pattern for 'docs/superpowers/plans/*.md' so planning outputs remain local and untracked.

.gitignore

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 📜 Skill insights (0)

Context used
✅ Compliance rules (platform): 54 rules

Grey Divider


Remediation recommended

1. README references deleted plan 🐞 Bug ⚙ Maintainability
Description
After deleting docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md, web/admin/README.md
still points to that file as the source of truth for production packaging. This leaves misleading
documentation and sends contributors to a path that no longer exists.
Code

docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md[1]

-# Fullsend admin installation SPA Implementation Plan
Relevance

⭐⭐⭐ High

Team actively fixes dangling/broken doc links; added link linter and corrected broken refs in past
PRs.

PR-#783
PR-#2009
PR-#2181

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The PR deletes the referenced plan document, but the README still claims it exists as the tracking
doc for production packaging; additionally, .gitignore now ignores future files in that plans
directory, reinforcing that this is not a stable tracked location.

web/admin/README.md[7-7]
.gitignore[25-25]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`web/admin/README.md` references an implementation plan file that this PR deletes (`docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md`). Readers will be directed to a non-existent path.

### Issue Context
This PR also adds `docs/superpowers/plans/*.md` to `.gitignore`, indicating these plan docs should no longer be treated as tracked project artifacts.

### Fix Focus Areas
- web/admin/README.md[7-7]

Update the sentence to either:
- point to the relevant *spec* docs that remain tracked (e.g. `docs/superpowers/specs/2026-04-06-fullsend-admin-spa-design.md` and/or `2026-04-21-fullsend-admin-spa-ux-design.md`), or
- remove the plan reference entirely if there is no replacement canonical doc.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

Qodo Logo

@@ -1,1213 +0,0 @@
# Fullsend admin installation SPA Implementation Plan

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remediation recommended

1. Readme references deleted plan 🐞 Bug ⚙ Maintainability

After deleting docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md, web/admin/README.md
still points to that file as the source of truth for production packaging. This leaves misleading
documentation and sends contributors to a path that no longer exists.
Agent Prompt
### Issue description
`web/admin/README.md` references an implementation plan file that this PR deletes (`docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md`). Readers will be directed to a non-existent path.

### Issue Context
This PR also adds `docs/superpowers/plans/*.md` to `.gitignore`, indicating these plan docs should no longer be treated as tracked project artifacts.

### Fix Focus Areas
- web/admin/README.md[7-7]

Update the sentence to either:
- point to the relevant *spec* docs that remain tracked (e.g. `docs/superpowers/specs/2026-04-06-fullsend-admin-spa-design.md` and/or `2026-04-21-fullsend-admin-spa-ux-design.md`), or
- remove the plan reference entirely if there is no replacement canonical doc.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

  • [stale-reference] web/admin/README.md:7 — Line 7 references docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md which is deleted by this PR and gitignored going forward, but the reference in this file is not cleaned up. The sentence reads: "Production packaging of this app for the public site is tracked in the repo-wide implementation plan (docs/superpowers/plans/2026-04-12-fullsend-admin-spa.md)." After this PR merges, this will be a dangling reference to a non-existent file. The PR cleaned up two similar references in the spec docs under docs/superpowers/specs/ but missed this one.
    Remediation: Remove or rewrite the sentence in web/admin/README.md line 7 that references the deleted plan file.

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Jul 8, 2026
@ralphbean ralphbean added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit 6f3b708 Jul 8, 2026
24 checks passed
@ralphbean ralphbean deleted the chore/gitignore-superpowers-plans branch July 8, 2026 14:38
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 8, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 2:41 PM UTC · Completed 2:50 PM UTC
Commit: 5c864d1 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3550 — chore: gitignore superpowers plan files

Timeline: ralphbean opened this human-authored PR at 12:54 UTC on 2026-07-08. It added docs/superpowers/plans/*.md to .gitignore, removed 10 tracked plan files, and cleaned up 2 dangling references in spec docs. The review agent completed at 13:05 UTC and found a medium-severity stale-reference bug: web/admin/README.md:7 still references a deleted plan file. Qodo independently flagged the same bug. rh-hemartin approved at 13:51 UTC without addressing either finding. ralphbean merged at 14:38 UTC. The dangling reference remains unfixed.

Key observations:

  • Both review bots correctly identified a real bug that the human reviewer ignored
  • The code agent assisting the author fixed 2 of 3 dangling references but missed the one in web/admin/README.md
  • The single medium-severity finding triggered the comment-only verdict per current rules, which provided no workflow friction to prevent merging with the bug present

Proposals

  1. Evidence for Review agent should use CHANGES_REQUESTED for medium-severity behavior-change and test-integrity findings #2940: medium-severity stale-reference finding posted with COMMENT verdict was ignored — PR merged with dangling reference still present
  2. Evidence for Code agent should grep-verify completeness after rename/terminology tasks #1794: code agent assisting the author found 2 of 3 dangling references but missed the third — grep-verify after file deletions would have caught it

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires-manual-review Review requires human judgment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants