Skip to content

docs(#3861): fix documentation nav inconsistencies#3868

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/3861-fix-docs-inconsistencies
Jul 10, 2026
Merged

docs(#3861): fix documentation nav inconsistencies#3868
rh-hemartin merged 1 commit into
mainfrom
agent/3861-fix-docs-inconsistencies

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Three documentation inconsistencies from PR #3398 are resolved:

  1. Add VitePress sidebar entry for default-vs-custom.md so the page
    is discoverable via site navigation.
  2. Align link text with target page H1 headings — change
    "Configuring..." to "Customizing..." across agent docs and
    guides README.
  3. Update sidebar title from "Building Custom Agents" to
    "Building custom agents from scratch" to match the page H1.

Closes #3861

Post-script verification

  • Branch is not main/master (agent/3861-fix-docs-inconsistencies)
  • Secret scan passed (gitleaks — b612dab8952bd07379cf21d78d16f4d3b7b41f16..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

@fullsend-ai-coder fullsend-ai-coder Bot requested a review from a team as a code owner July 9, 2026 12:34
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Jul 9, 2026
Three documentation inconsistencies from PR #3398 are resolved:

1. Add VitePress sidebar entry for default-vs-custom.md so the page
   is discoverable via site navigation.
2. Align link text with target page H1 headings — change
   "Configuring..." to "Customizing..." across agent docs and
   guides README.
3. Update sidebar title from "Building Custom Agents" to
   "Building custom agents from scratch" to match the page H1.

Closes #3861
@rh-hemartin rh-hemartin force-pushed the agent/3861-fix-docs-inconsistencies branch from 4f0c224 to 9cd4c71 Compare July 10, 2026 10:02
@rh-hemartin rh-hemartin enabled auto-merge July 10, 2026 10:02
@github-actions

Copy link
Copy Markdown

E2E tests did not run

E2E tests run automatically for org/repo members and collaborators on pull requests.

For other contributors, a maintainer must add the ok-to-test label after the latest push.

See E2E testing guide for details.

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://497d2ea0-site.fullsend-ai.workers.dev

Commit: 9cd4c713af9714e883e37a35aa6cd31f8759c9bd

@rh-hemartin rh-hemartin added this pull request to the merge queue Jul 10, 2026
@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Merged via the queue into main with commit 29a94e5 Jul 10, 2026
14 checks passed
@rh-hemartin rh-hemartin deleted the agent/3861-fix-docs-inconsistencies branch July 10, 2026 10:08
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 10, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 10:10 AM UTC · Completed 10:29 AM UTC
Commit: 9cd4c71 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #3868 — docs(#3861): fix documentation nav inconsistencies

Workflow quality: Good overall. The full retro→triage→code pipeline worked well for this concrete docs fix. The code agent correctly fixed all 3 identified inconsistencies from PR #3398 in a single clean commit with 8 precise file changes, completing in ~11 minutes.

Key finding: review agent never dispatched. No review agent ran on this PR — or on any of the 4 most recent code-agent PRs in this repo (#3868, #3448, #3286, #3156). The post-code.sh script applies the ready-for-review label as a workaround for bot users failing the pull_request_target.opened authorization check, but the label-based dispatch path is not triggering.

Proposals filed

  1. Review agent dispatch gap for code-agent PRs — The label-based bot-to-bot handoff described in ADR 0054 is not working for PR labels. Code-agent PRs skip automated review entirely.
  2. VitePress sidebar still missing entries for behaviour-testing docs — Two dev docs added in recent PRs are missing from the sidebar config, the same class of issue PR docs(#3861): fix documentation nav inconsistencies #3868 fixed.

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review Agent PR ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Evidence for #1956: 3 docs inconsistencies from PR #3398 merged without follow-up tracking

1 participant