This repository was archived by the owner on May 4, 2024. It is now read-only.
PR to fix Issue #29 - Mobile menu not respecting device viewport#35
Open
ryandotfurrer wants to merge 9 commits intofullstack-chat:mainfrom
Open
PR to fix Issue #29 - Mobile menu not respecting device viewport#35ryandotfurrer wants to merge 9 commits intofullstack-chat:mainfrom
ryandotfurrer wants to merge 9 commits intofullstack-chat:mainfrom
Conversation
added 2 commits
September 1, 2023 16:55
- installed gatsby cli - performed `npm run` - installed react-icons - performed `npm audit fix` and `npm fund`
Changed ul height from 100vh to 100dvh. Fix could not be tested just yet due to "on your network" not working on my phone. Will try again when I get home.
ryandotfurrer
changed the title
Member
Author
ryandotfurrer
changed the title
- font-family to "font-sans" - margin to "m-0" - padding to "p-0" - line-height to "leading-normal" - background-color to "bg-zinc-900"
The <H1 /> component was created to keep styling consistent across the board. It has one Prop named "heading," which has a type of string.
To serve as a template for any external link needed, since any internal links use the <Link /> API in Gatsby. The <ExternalLink /> Component looks for two props, "href" and "textToShow" both of which are strings. Since you only use this for external links, opening in a new tab is assumed, as well as limiting the trackers using the "rel" attribute. Lastly, state is used to help toggle the appropriate styles. Removed redundant styles in global.css with the creation of this component.
- href was not passed as a prop, thus `<ExternalLink />` was not passing through anything. - Changed the navbar Blog link from `a` to `ExternalLink` component.
- any internal link will now close the mobile menu upon click - working on a fix for the `ExternalLink` component.
Contributor
|
@ryanfurrer can you merge in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I confirmed that the Navbar
ulchange from100vhto100dvhworked.The issue can be closed out.