refactor(billing): rename GraceWindowDays to GracePeriodDays#1313
Merged
iammukeshm merged 1 commit intoJun 24, 2026
Merged
Conversation
The tenant billing grace span is named "grace window" in code (GraceWindowDays option in both TenantBillingOptions and Identity's TenantGraceOptions, the Billing:GraceWindowDays config key, and the _graceWindowDays field) while every user-facing and conceptual reference calls it the grace period. "Grace period" is the standard SaaS billing term; standardize the vocabulary on it. - Rename the GraceWindowDays property in both options classes, the bound config key (Billing:GraceWindowDays -> Billing:GracePeriodDays), all references, and the _graceWindowDays field to GracePeriodDays. - Align the surrounding comments/XML docs that still said "grace window". BREAKING (config): deployments setting Billing:GraceWindowDays must rename the key to Billing:GracePeriodDays. The default (7 days) is unchanged. No public contract change: the GraceEndsUtc DTO/event fields are untouched.
Member
|
Thanks @marcelo-maciel — clean, consistent standardization on the conventional SaaS term. Just a reminder to land the companion changelog entry in the docs repo for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The tenant billing grace span is named "grace window" in code (
GraceWindowDaysin bothTenantBillingOptionsand Identity'sTenantGraceOptions, theBilling:GraceWindowDaysconfig key, and the_graceWindowDaysfield) while the user-facing and conceptual references call it the grace period. "Grace period" is the standard SaaS billing term; this standardizes the vocabulary on it.Changes
GraceWindowDays→GracePeriodDaysin both options classes, all references, and the_graceWindowDaysfield.Billing:GraceWindowDays→Billing:GracePeriodDays.Breaking change (config)
Deployments that set
Billing:GraceWindowDaysmust rename the key toBilling:GracePeriodDays. The default (7 days) is unchanged.Notes
GraceEndsUtcDTO/event fields are untouched.TreatWarningsAsErrors).fullstackhero/docs.