chore(host): point default CORS allow-list at the React client origins#1324
Open
marcelo-maciel wants to merge 1 commit into
Open
chore(host): point default CORS allow-list at the React client origins#1324marcelo-maciel wants to merge 1 commit into
marcelo-maciel wants to merge 1 commit into
Conversation
`CorsOptions.AllowedOrigins` still listed `https://localhost:4200` (Angular) and `https://localhost:7140`, neither of which any shipped client uses. The two front-ends this kit runs are `clients/admin` (http://localhost:5173) and `clients/dashboard` (http://localhost:5174). List those instead so the default dev config actually matches the apps.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
CorsOptions.AllowedOriginsinappsettings.jsonlistedhttps://localhost:4200(Angular's default dev port) andhttps://localhost:7140, neither of which any client in this repo uses.The two front-ends the kit actually ships and runs (via the Aspire AppHost) are:
clients/admin→http://localhost:5173clients/dashboard→http://localhost:5174This replaces the stale entries with the real React dev origins so the default configuration matches the apps out of the box.
Note
This touches the same
AllowedOriginsblock as #1323 (per-request front-end origin resolution), which adds:5173/:5174on top of the existing entries. Whichever merges first, the other will need a trivial rebase of this one array. Happy to sequence them however you prefer.