Skip to content

[chore]: Update prettier#927

Closed
emilyhernandez wants to merge 2 commits into
mainfrom
chore-update-prettier
Closed

[chore]: Update prettier#927
emilyhernandez wants to merge 2 commits into
mainfrom
chore-update-prettier

Conversation

@emilyhernandez
Copy link
Copy Markdown
Contributor

@emilyhernandez emilyhernandez commented May 22, 2026

DS-661

Updated Prettier, since v3.8.2 added support for Angular v21.2 which is what Fudis is soon transitioning to (#926 ).

Developer's checklist

  • I wrote necessary unit tests
  • I updated Storybook stories and documentation to reflect the latest changes
  • I included visual regression tests for new UI design
  • I tested my implementation with different browsers
  • I checked accessibility according to Web Content Accessibility Guidelines 2.1
  • Together with the reviewer I can confirm that the implementation supports the following screenreader and browser combinations (NVDA + Firefox, VoiceOver + Chrome)

@emilyhernandez emilyhernandez added the dependencies Updating dependencies label May 22, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Lines Statements Branches Functions
Coverage: 94%
94.82% (13696/14444) 89.28% (1425/1596) 91.08% (531/583)
Coverage Report • (94%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files94.8289.2891.0894.82 
report-only-changed-files is enabled. No files were changed in this commit :)

@emilyhernandez emilyhernandez marked this pull request as ready for review May 22, 2026 08:17
Comment thread package-lock.json
"version": "3.8.1",
"resolved": "https://registry.npmjs.org/prettier/-/prettier-3.8.1.tgz",
"integrity": "sha512-UOnG6LftzbdaHZcKoPFtOcCKztrQ57WkHDeRD9t/PTQtmT0NHSeWWepj6pS0z/N7+08BHFDQVUrfmfMRcZwbMg==",
"version": "3.8.3",
Copy link
Copy Markdown
Contributor

@RiinaKuu RiinaKuu May 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually want to keep our package.json and lock-file versions in sync, just for consistency/readability. But since we don't need to force the use of 3.8.3, we can let it be as is.

@RiinaKuu
Copy link
Copy Markdown
Contributor

RiinaKuu commented May 26, 2026

I noticed there was dependabot pull (with green pipeline) with the same update, so I decided to merge that, since the current developer is absent. Will close this PR.

@RiinaKuu RiinaKuu closed this May 26, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Updating dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants