Open
Conversation
labenu-bot
approved these changes
Aug 1, 2022
labenu-bot
left a comment
labenu-bot
left a comment
There was a problem hiding this comment.
Parabéns pela entrega!
Requisitos do projeto ✅
| Implementações | Feito |
|---|---|
| É possível ver uma lista com todos os pokemons | ✅ |
| É possivel fazer uma busca por um pokemom específico | ✅ |
| É possivel filtrar pokemons por um ou mais parâmetros. | ✅ |
| Contém paginação | ✅ |
| Transformou o arquivo exel em json | - |
| Usou algum banco de dados | ✅ |
| Enviou os dados json já existentes para banco de dados | ✅ |
| Separou responsabilidades usando os princícios de arquitetura de softWare | ✅ |
| Criou uma entidade para pokemon | ✅ |
| Criou documentação do Postman | ✅ |
| Criou um 'README' explicando como executar o projeto | ✅ |
| Usou docker. | - |
| Fez testes unitários | - |
| Feedback do código | Feito |
|---|---|
| Isolou as configurações do servidor das lógicas de negócio | ✅ |
| Isolou as entidades da aplicação | ✅ |
| Tratou corretamente os erros | ✅ |
Análise realizada por: Gabriel Mina
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RedFoxTech
Teste Case: https://github.com/RedFoxTech/vaga-backend-teste
Heroku
Documentação