Explicit bounds for 'approveTokens' and 'showAllowance'#4
Open
ilya-bobyr wants to merge 1 commit intomasterfrom
Open
Explicit bounds for 'approveTokens' and 'showAllowance'#4ilya-bobyr wants to merge 1 commit intomasterfrom
ilya-bobyr wants to merge 1 commit intomasterfrom
Conversation
ilya-bobyr
force-pushed
the
showAllowance
branch
from
c4be9e4 to
74c4f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figured, it would be nice to be able to see the approved values, via the CLI.
Also changed the
approveTokensto accept the amounts ofassetandstable.There was a slight bug in the previous implementation, as it was using the same amount of digits for both asset and stable tokens, effectively approving 10^12 times more stable than asset.
It was just for testing, so it is not that big of a deal :)
This change is