Skip to content

Fix wrong checkCipherHashIsAvailable compare param#4

Open
fvromera wants to merge 1 commit into
masterfrom
fvromera-patch-crypt-wrong-hash-algo
Open

Fix wrong checkCipherHashIsAvailable compare param#4
fvromera wants to merge 1 commit into
masterfrom
fvromera-patch-crypt-wrong-hash-algo

Conversation

@fvromera
Copy link
Copy Markdown
Owner

@fvromera fvromera commented Mar 13, 2023

You can't specify $crypt->setHashAlgorithm('sha256'); because of a wrong use of compare "hash" === cipher in function Crypt->checkCipherHashIsAvailable

Hello!

  • Type: bug fix | new feature | code quality | documentation
  • Link to issue:

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Thanks

You can't specify $crypt->setHashAlgorithm('sha256'); because of a wrong use of compare "hash" === cipher in function Crypt->checkCipherHashIsAvailable
@fvromera
Copy link
Copy Markdown
Owner Author

This solve a little bug checking your system about ciphers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant