Compiler/platform based optimisation flags#144
Open
sdassow wants to merge 10 commits into
Open
Conversation
…able with platform specific optimization flags
…ction but disabled for windows/mingw, and add more tests
andydotxyz
reviewed
Jul 12, 2026
andydotxyz
left a comment
andydotxyz
left a comment
Member
There was a problem hiding this comment.
Looks great thanks, just a few notes on naming
| } | ||
|
|
||
| var hardeningFlagsTable = []hardeningFlags{ | ||
| {"ubuntu", "amd64", "gcc", "*", "11.4.0", "-fcf-protection -fstack-protector-strong"}, // https://github.com/fyne-io/tools/issues/137 |
Member
There was a problem hiding this comment.
This probably deserves at least a hint at the headline. I'd put a few words and then just "issue #137" instead of using space for the URL
Contributor
Author
There was a problem hiding this comment.
Fully aggree, fixed.
| return string(out) | ||
| } | ||
|
|
||
| func hardeningFlagsLookup(out, goos, arch string) string { |
Member
There was a problem hiding this comment.
Maybe it should be hardeningCFlagsLookup for avoidance of doubt?
| os, arch, cc, minVer, maxVer, cflags string | ||
| } | ||
|
|
||
| var hardeningFlagsTable = []hardeningFlags{ |
Member
There was a problem hiding this comment.
hardeningCFlagsTable I think - to avoid ldflags confusion
Contributor
Author
There was a problem hiding this comment.
Depends I think. Would ldflags fit in there if needed or would they get a separate table?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add function to detect compiler information and use it for a lookup table with platform specific optimisation flags. Should fix #137.