Fix fyne release --os android not respecting ldflags present in GOFLAGS environment variable#70
Open
petoem wants to merge 4 commits into
Open
Fix fyne release --os android not respecting ldflags present in GOFLAGS environment variable#70petoem wants to merge 4 commits into
fyne release --os android not respecting ldflags present in GOFLAGS environment variable#70petoem wants to merge 4 commits into
Conversation
- Changed `GOFLAGS` is actually now in the `env` slice - Global enviroment is not changed
…GOFLAGS` enviroment variable
Contributor
|
Without having worked in that particular area of the code, it reminds me of #17. |
Author
|
Looked at it again. #17 fixes windows builds by not changing the environment, but that's different for android. I explain more about this PR:
This pull request probably fixes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #69