feat(streams): implement stream top-up endpoint (#595)#3
Open
fytgian wants to merge 1 commit into
Open
Conversation
- POST /v1/api/streams/:stream_id/top-up accepts employer + amount - Validates stream exists via get_stream contract call - Rejects top-up if stream status is not Active - Calls top_up(employer, stream_id, amount) on Soroban contract - Invalidates stream cache after successful top-up - Full input validation (stream_id, employer address, amount > 0) - Swagger JSDoc documented
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes Vera3289#595
Adds the ability for employers to top up existing streams with additional funds without cancellation.
Changes
Modified files
api/routes/streams.js— AddedPOST /:stream_id/top-uprouteHow it works
stream_id(integer ≥ 1),employer(Stellar G-address), andamount(positive integer string)get_streamon the Soroban contract to verify the stream existsActivestatus (cannot top-up Paused/Cancelled/Exhausted streams)top_up(employer, stream_id, amount)transaction to the Soroban contractGET /:stream_idreflects the updated deposit{ success, stream_id, amount_added, transaction_hash }Acceptance Criteria
POST /v1/api/streams/:stream_id/top-upget_streamcall + status check before submissiontop_upSoroban contract callBASE_FEEset instellarServicetransaction_hashfrom confirmed tx