fix(zilean): percent-encode DMM query titles#570
Conversation
WalkthroughAdded URL encoding to the query parameter in the Zilean scraper's Changes
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR fixes malformed Zilean DMM lookups by percent-encoding the query title value in the /dmm/filtered request URL so titles containing spaces, punctuation, or non-ASCII characters are transmitted safely.
Changes:
- Add
urllib.parse.quoteusage to percent-encoderequest.titlein the Zilean DMM filtered query URL. - Preserve existing season/episode query behavior for series requests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
queryparameter so titles with spaces, parentheses,&,+, and non-ASCII characters are sent safelyrequest.titlewithurllib.parse.quote(..., safe='')showsuffix untouchedWhy
comet/scrapers/zilean.pycurrently interpolatesrequest.titledirectly into the URL query string/dmm/filtered?query=...requests deterministic without changing behavior for simple titlesNotes
zilean.pycomet/scrapers/prowlarr.py; that can be handled separately