Skip to content

G2-1741 Avoid overload of asList(...) which breaks Path handling #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gdgib merged 1 commit into from
Mar 20, 2025
Merged

G2-1741 Avoid overload of asList(...) which breaks Path handling #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pj-report/src/main/java/com/g2forge/project/report/Billing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ protected List<Issue> findRelevantIssues(ExtendedJiraRestClient client, Collecti
final SearchResult searchResult = client.getSearchClient().searchJql(jql, max, base, null).get();
log.info("Got issues {} to {} of {}", base, base + Math.min(searchResult.getMaxResults(), searchResult.getTotal() - base), searchResult.getTotal());

retVal.addAll(HCollection.asList(searchResult.getIssues()));
retVal.addAll(HCollection.asListIterable(searchResult.getIssues()));
if ((base + max) >= searchResult.getTotal()) break;
else base += max;
}
Expand All @@ -212,7 +212,7 @@ public IExit invoke(CommandInvocation<InputStream, PrintStream> invocation) thro
final List<Issue> relevantIssues = findRelevantIssues(client, request.getUsers().keySet(), request.getStart(), request.getEnd());
log.info("Found: {}", relevantIssues.stream().map(Issue::getKey).collect(HCollector.joining(", ", ", & ")));
for (Issue issue : relevantIssues) {
final Set<String> components = HCollection.asList(issue.getComponents()).stream().map(BasicComponent::getName).collect(Collectors.toSet());
final Set<String> components = HCollection.asListIterable(issue.getComponents()).stream().map(BasicComponent::getName).collect(Collectors.toSet());
final Set<String> billableComponents = HCollection.intersection(components, request.getBillableComponents());
if (billableComponents.isEmpty()) continue;

Expand Down