Skip to content

fix(ci): atomic fix for #46 deadlock — rename job + cargo fmt#49

Open
gHashTag wants to merge 1 commit into
mainfrom
fix/ci-naming-fmt-atomic
Open

fix(ci): atomic fix for #46 deadlock — rename job + cargo fmt#49
gHashTag wants to merge 1 commit into
mainfrom
fix/ci-naming-fmt-atomic

Conversation

@gHashTag
Copy link
Copy Markdown
Owner

🎯 Goal

Resolve the CI naming deadlock in one atomic commit.

🐛 Deadlock situation

PR #43 (fmt)   → BLOCKED  → waits for "ci" check (doesn't exist)
PR #47 (rename)→ FAILING  → cargo fmt check finds unformatted code

Both PRs need each other to proceed — circular dependency.

✅ Atomic fix

This PR combines both changes in one commit:

  1. Rename job build-and-testci in .github/workflows/ci.yml
  2. Apply cargo fmt to satisfy the 'ci' job's formatting check

Result: CI job runs with name "ci" (matches branch protection) + code is formatted → CLEAN

📋 Files changed

  • .github/workflows/ci.yml — job rename + docker needs update
  • src/bin/cpu_train.rs — fmt
  • src/model_hybrid_attn.rs — fmt
  • src/train_loop.rs — fmt

✅ Acceptance

Closes #46
Related to #43

φ² + φ⁻² = 3 · TRINITY · NEVER STOP

#46 deadlock)

This PR resolves the CI naming deadlock in one atomic commit:
- Renames job 'build-and-test' → 'ci' to match branch protection
- Applies cargo fmt to satisfy the 'ci' job's formatting check

Root cause: GitHub registers status-check name as job name, not workflow name.
Without both changes together, we get a deadlock:
- PR #43 (fmt) is BLOCKED waiting for "ci" check
- PR #47 (rename) FAILS on unformatted code

Fix: combine both changes in one commit → CI passes → PR becomes CLEAN.

Closes #46
Related to #43

φ² + φ⁻² = 3 · TRINITY · NEVER STOP
@gHashTag gHashTag force-pushed the fix/ci-naming-fmt-atomic branch from 8988d08 to f77d3a2 Compare April 29, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CHORE] CI workflow naming mismatch blocks all PR merges

1 participant