fix(ci): atomic fix for #46 deadlock — rename job + cargo fmt#49
Open
gHashTag wants to merge 1 commit into
Open
fix(ci): atomic fix for #46 deadlock — rename job + cargo fmt#49gHashTag wants to merge 1 commit into
gHashTag wants to merge 1 commit into
Conversation
#46 deadlock) This PR resolves the CI naming deadlock in one atomic commit: - Renames job 'build-and-test' → 'ci' to match branch protection - Applies cargo fmt to satisfy the 'ci' job's formatting check Root cause: GitHub registers status-check name as job name, not workflow name. Without both changes together, we get a deadlock: - PR #43 (fmt) is BLOCKED waiting for "ci" check - PR #47 (rename) FAILS on unformatted code Fix: combine both changes in one commit → CI passes → PR becomes CLEAN. Closes #46 Related to #43 φ² + φ⁻² = 3 · TRINITY · NEVER STOP
8988d08 to
f77d3a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Resolve the CI naming deadlock in one atomic commit.
🐛 Deadlock situation
✅ Atomic fix
This PR combines both changes in one commit:
build-and-test→ciin.github/workflows/ci.ymlResult: CI job runs with name "ci" (matches branch protection) + code is formatted → CLEAN
📋 Files changed
.github/workflows/ci.yml— job rename + docker needs updatesrc/bin/cpu_train.rs— fmtsrc/model_hybrid_attn.rs— fmtsrc/train_loop.rs— fmt✅ Acceptance
required_status_checks.contexts = ["ci"]Closes #46
Related to #43
φ² + φ⁻² = 3 · TRINITY · NEVER STOP