Skip to content

Update GitHub Actions to run on latest Nim version#31

Open
gabbhack wants to merge 2 commits intomasterfrom
update-github-actions-nim-stable-7699856970249666261
Open

Update GitHub Actions to run on latest Nim version#31
gabbhack wants to merge 2 commits intomasterfrom
update-github-actions-nim-stable-7699856970249666261

Conversation

@gabbhack
Copy link
Copy Markdown
Owner

Updates the GitHub Actions workflows (tests.yml and docs.yml) to run tests and build documentation on the latest stable Nim version. Additionally, updates the actions used (checkout, cache, setup-nim-action) to their latest stable versions to prevent Node.js deprecation warnings.


PR created automatically by Jules for task 7699856970249666261 started by @gabbhack

- Added 'stable' to the Nim version matrix in `tests.yml`.
- Updated `nim-version` to `stable` in `docs.yml`.
- Updated `actions/checkout` and `actions/cache` to `v4`.
- Updated `jiro4989/setup-nim-action` to `v2` to avoid node12/16 deprecation warnings.

Co-authored-by: gabbhack <43146729+gabbhack@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gabbhack
Copy link
Copy Markdown
Owner Author

Use concrete latest version instead of stable and make tests for versions run in parallel and independently

- Updated github actions workflow to test against a concrete latest Nim version 2.2.8
- Updated `fail-fast: false` to strategy matrix so that tests for versions run in parallel and independently
- Fixed compilation error in `src/deser/des/helpers.nim` where dead code after `{.noreturn.}` functions triggered warnings on newer Nim versions

Co-authored-by: gabbhack <43146729+gabbhack@users.noreply.github.com>
@gabbhack
Copy link
Copy Markdown
Owner Author

Fix tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant