Adds autoUpdateAnchorHash option, default to true#70
Open
mendes5 wants to merge 3 commits intogabergg:masterfrom
Open
Adds autoUpdateAnchorHash option, default to true#70mendes5 wants to merge 3 commits intogabergg:masterfrom
mendes5 wants to merge 3 commits intogabergg:masterfrom
Conversation
|
I've added a version of this library to my library collection that has some added improvements already, for example this one. https://www.npmjs.com/package/@marzahn-dev/react-scroll-anchor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the need to configure the library to not automatically update the URL hash during scroll events, the library currently doesn't support this. This PR adds the
autoUpdateAnchorHashoption, so you can configure it when calling theconfigureAnchorsfunction.While this PR isn't merged our team will be using
@fernando-msj/react-scrollable-anchor.