Skip to content

tests: stabilize post-release health checks#90

Merged
gaelic-ghost merged 2 commits into
mainfrom
fix/post-release-health
Jun 11, 2026
Merged

tests: stabilize post-release health checks#90
gaelic-ghost merged 2 commits into
mainfrom
fix/post-release-health

Conversation

@gaelic-ghost

@gaelic-ghost gaelic-ghost commented Jun 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • update README and ROADMAP for the published v1.7.2 state
  • stabilize async observable tests under full-suite scheduling
  • remove the SPI refresh note from the roadmap

Verification

  • swift test
  • bash scripts/repo-maintenance/validate-all.sh
  • git diff --check

Summary by CodeRabbit

  • Documentation

    • Updated README to confirm v1.7.2 as the current published release with updated release notes reference
    • Updated ROADMAP to mark v1.7.2 as shipped and added release history entry
  • Tests

    • Enhanced test implementations for improved polling behavior and cache policy verification

@gaelic-ghost gaelic-ghost merged commit 94019a8 into main Jun 11, 2026
@gaelic-ghost gaelic-ghost deleted the fix/post-release-health branch June 11, 2026 17:30
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2689df98-94a9-49c1-8c00-240e61345c50

📥 Commits

Reviewing files that changed from the base of the PR and between 62dc85d and 47d2b91.

📒 Files selected for processing (4)
  • README.md
  • ROADMAP.md
  • Tests/SwiftASBTests/Public/CodexAppServerRecentTurnCachePolicyTests.swift
  • Tests/SwiftASBTests/Public/CodexAppServerTestSupport.swift

📝 Walkthrough

Walkthrough

PR documents v1.7.2 as a published release in README and ROADMAP, marking PolyForm licensing as shipped and completing the release checklist. Two test changes relax assertion verification and add polling delay to reduce flakiness in cache policy and observable state tests.

Changes

v1.7.2 Release Documentation

Layer / File(s) Summary
README status and release notes
README.md
Status line updated to describe v1.7.2 as current published release; Release Notes section now refers to final release notes instead of draft.
ROADMAP release tracking updates
ROADMAP.md
Swift Package Index readiness entry cleaned up; PolyForm Noncommercial status marked Shipped; v1.7.2 checklist completed with final release workflow decision; History section records v1.7.2 publication date and shipped deliverables (ASBPresentation foundation, ASBAppKit sidebar view, Codex CLI 0.138.x generated-wire refresh, PolyForm license transition).

Test Reliability Improvements

Layer / File(s) Summary
Cache policy test assertion relaxation
Tests/SwiftASBTests/Public/CodexAppServerRecentTurnCachePolicyTests.swift
scrollPositionBindingTriggersOlderPrefetch now verifies only the first 5 method calls match expected sequence and asserts at least two "thread/turns/list" calls occurred, replacing exact array equality to reduce test flakiness.
Test polling timing adjustment
Tests/SwiftASBTests/Public/CodexAppServerTestSupport.swift
waitForObservableState adds a 1ms Task.sleep after task yield in polling loop to reduce timing sensitivity.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

documentation

Poem

🐰 The release hops forward, v1.7.2 now shipped,
PolyForm licensed, new views have clipped,
Tests breathe easier with gentler assertions,
And timing adjustments smooth out the perturbations,
Documentation blooms, marking the journey complete! 🎉

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/post-release-health

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant