Fix the gas_injection mappings for EAST#402
Merged
Conversation
These mappings have been out of date for a few years and cause the tests to fail when run on Omega. It turns out test_mongo actually checks these, but it's not clear why this wasn't encountered sooner. It's likely a result of some recent build clean-up that it is now being seen.
Collaborator
Author
|
I'm going to push the merge ahead without review since it only affects mappings that were broken to start with, suggesting they haven't been used in a long time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These mappings have been out of date for a few years and cause the tests to fail when run on Omega. It turns out test_mongo actually checks these, but it's not clear why this wasn't encountered sooner. It's likely a result of some recent build clean-up that it is now being seen.
Type of Change
Testing
make testPre-Merge Checklist
omas/versionfile0.94.2→0.94.3for bug fixes,0.94.2→0.95.0for new features)