fix: avoid throwing in warn mode for invalid types#283
Open
robinchen0127-star wants to merge 1 commit intogajus:masterfrom
Open
fix: avoid throwing in warn mode for invalid types#283robinchen0127-star wants to merge 1 commit intogajus:masterfrom
robinchen0127-star wants to merge 1 commit intogajus:masterfrom
Conversation
2 tasks
Author
|
Quick follow-up: this PR is ready for review. It keeps assert-mode behavior intact, replaces the warn-mode throw with a validation error, and includes the regression coverage noted in the PR body. Local targeted and full mocha runs passed on my side. Happy to adjust anything if you'd like the fix narrowed further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary
warn: truestill throws for invalid$Shape(...)constructions because$ShapeType.errors()raises an invariant instead of yielding a validation error. That makest.check()/t.warn()escape instead of logging a warning.Solution Approach
$ShapeType.errors()invariant with a yielded validation error tupleassertbehavior intact by covering the same invalid construction under assert modeTest Evidence
Closes #113