Add a test that a tool with id kraken2000 will not inherit parameters for kraken2#124
Add a test that a tool with id kraken2000 will not inherit parameters for kraken2#124cat-bro wants to merge 2 commits intogalaxyproject:mainfrom
Conversation
|
My initial reaction was that this may confuse new users, although this is technically not a bug. It only happens if we forget that the tool id is meant to be a regex. As such, kraken2 would naturally match anything that kraken2000 matches. We could document the need for a Alternatively, we could let TPV forcibly insert the $ sign - I tried this out and it does work. The documentation changes however to "entity id is a regex, but with an EOL anchor auto-inserted at the end". I don't expect that this will break anything in the wild, even for complicated regexes, since the actual tool id always has an EOL at the end. @bgruening @natefoo @mira-miracoli thoughts? If we go with the 2nd option, it's technically a breaking change, although in practical terms, I doubt that anyone relies on this behaviour. |
|
I don't have a strong preference, but I think it would be technically cleaner to stick to the current version and add a |
|
We have been sticking |
This is a broken test based a scenario we discovered on Galaxy Australia. A tool will inherit parameters from a tool with an ID which is the substring of the tool's ID. This is likely to have unwanted side effects.