Conversation
This shrinks the search space for searching for equilibria on a given support to be in the interior of the simplex (rather than including the boundaries as before). This solves the behaviour noted in #756, in which degenerate situations which required a solution to be on the boundary would be very slow as it tried to approach the solution on the boundary.
Member
Author
|
@rahulsavani This deals with the coordination game cases you provided (in both extensive and strategic form). However, it does also have the effect that it changes the order in which equilibria are returned so it breaks the "ordered" tests. So it would seem to make sense to park this until you complete the test suite renovation, which should then make it easier to update the test suite (and to check that it's got good coverage on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shrinks the search space for searching for equilibria on a given support to be in the interior of the simplex (rather than including the boundaries as before).
This solves the behaviour noted in #756, in which degenerate situations which required a solution to be on
the boundary would be very slow as it tried
to approach the solution on the boundary.