Skip to content

add helm-values-command (helm-values from OCM-image-mappings)#1530

Merged
ccwienk merged 2 commits intomasterfrom
helm-values
Feb 27, 2026
Merged

add helm-values-command (helm-values from OCM-image-mappings)#1530
ccwienk merged 2 commits intomasterfrom
helm-values

Conversation

@ccwienk
Copy link
Member

@ccwienk ccwienk commented Feb 23, 2026

Release note:


@gardener-prow gardener-prow bot added the do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 23, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ccwienk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2026
help='generates localised helm-values',
)
helmvalues_parser.add_argument(
'--component', '-c',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Please let us consistently use either --component or --name (or both)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh dear. I also noticed this inconsistency. With the current commands, we have two conventions:

  1. if the only parameter is an ocm-component-name, --name is used
  2. if this is not the case, --component is used

I agree this inconsistency is not nice indeed. Will update for this new command + hope to not forget about making other commands consistent in another change.

@kayrus
Copy link

kayrus commented Feb 24, 2026

@ccwienk according to lss templates, I see there are two different helm-values:

  1. admission_helm_values
  2. %EXTENSION%_helm_values

It seems that this PR implements only %EXTENSION%_helm_values. What about the admission helm-values?

Also, from the ops perspective I don't care about the required --resource. I have three sinks for values:

$ kubectl get crd extensions.operator.gardener.cloud -o yaml | yq '.spec.versions[].schema.openAPIV3Schema.properties.spec.properties.deployment' | yq '.. | select(has("x-kubernetes-preserve-unknown-fields")) | path | map(select(. != "properties")) | join(".")' 
admission.values
extension.runtimeClusterValues
extension.values

I want to have an ability to populate only three of these, and I have zero clue about what resource name to specify. Is it possible to completely remove the --resource argument?

UPD: also the aws provider extension contains an extra images value: https://github.com/gardener/gardener-extension-provider-aws/blob/c246b59dbdabb168a084ccdf804cd3e39f5e430e/charts/gardener-extension-provider-aws/values.yaml#L6-L8 Is there a way to automatically resolve and generate values for these images as well?

Some sub-commands would specify a shortened version `--ocm-repo`.
Consistently accept `--ocm-repository`. As all of `--ocm-repo` is a
prefix of `--ocm-repository`, this change is backwards-compatible
(callers may still call with `--ocm-repo`), hence this change should be
okay w/o any additional measures (for backwards-compatibility).
@ccwienk ccwienk merged commit 275c803 into master Feb 27, 2026
8 of 9 checks passed
@ccwienk ccwienk deleted the helm-values branch February 27, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants