Update documentation regarding node deletion changes#1067
Merged
gardener-prow[bot] merged 3 commits intogardener:masterfrom Feb 24, 2026
Merged
Update documentation regarding node deletion changes#1067gardener-prow[bot] merged 3 commits intogardener:masterfrom
gardener-prow[bot] merged 3 commits intogardener:masterfrom
Conversation
gardener-prow
bot
added
do-not-merge/needs-kind
aaronfern
reviewed
Feb 16, 2026
docs/faq.md
Outdated
| On the other hand if the user deletes the node object immedietly then replacement will start only after `MachineHealthTimeout`. | ||
|
|
||
| This annotation can also be used if the user wants to expedite the [replacement of unhealthy nodes](#how-does-rate-limiting-replacement-of-machine-work-in-mcm-how-is-it-related-to-meltdown-protection) | ||
| If the user deletes the node object, the corresponding machine object is marked for deletion immediately, triggering a replacement. The replacement machine is created to maintain the `desired replicas` specified for the machineDeployment/machineSet. |
Member
There was a problem hiding this comment.
imo, the answer here answers the question "what happens if I delete a node object" rather than what it's supposed to answer. I've given a suggestion but please feel free to improvise or change the direction
Suggested change
| If the user deletes the node object, the corresponding machine object is marked for deletion immediately, triggering a replacement. The replacement machine is created to maintain the `desired replicas` specified for the machineDeployment/machineSet. | |
| If the user doesn't have access to the machine object, they can directly delete the node object. This causes the corresponding machine object to be immediately marked for deletion, triggering a replacement. The replacement machine is created to maintain the `desired replicas` specified for the machineDeployment/machineSet. |
takoverflow
requested changes
Feb 16, 2026
takoverflow
previously approved these changes
Feb 20, 2026
|
LGTM label has been added. DetailsGit tree hash: f618ad90a19d1902da7ba02ad0b6f78585669736 |
gardener-prow
bot
added
the
approved
takoverflow
removed
approved
takoverflow
dismissed
their stale review
Forgot that with prow now, just one approval's enough for PR to be auto merged.
|
LGTM label has been added. DetailsGit tree hash: f618ad90a19d1902da7ba02ad0b6f78585669736 |
takoverflow
approved these changes
Feb 24, 2026
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: takoverflow The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
takoverflow
added
kind/enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR updates documentation to account for changes made by #1055 , regarding the
node.machine.sapcloud.io/trigger-deletion-by-mcmannotation.docs/faq.mdto clarify that deleting a node now immediately triggers the deletion and replacement of the corresponding machine, and that thetrigger-deletion-by-mcmannotation is no longer supported on node objects but is still supported on machine and machineDeployment objects for CA-MCM integration.TriggerDeletionByMCMinpkg/util/provider/machineutils/utils.goRelease note: