feat(ship): skip version-bump/CHANGELOG/title-rewrite when the repo has no VERSION file#2343
Open
merit-blake wants to merge 1 commit into
Open
feat(ship): skip version-bump/CHANGELOG/title-rewrite when the repo has no VERSION file#2343merit-blake wants to merge 1 commit into
merit-blake wants to merge 1 commit into
Conversation
…as no VERSION file Repos that stamp versions at release/queue time (merge-queue driven repos, release-please/tag-based flows) have no VERSION file, but /ship today manufactures one: gstack-version-bump treats a missing file as 0.0.0.0, classifies FRESH, and `write` creates VERSION at the bumped slot - then writes a CHANGELOG release heading and rewrites the PR title to vX.Y.Z.W. On a queue-managed repo every such PR textually collides with every other (we hit three pairs of open PRs claiming identical versions in one repo before tracing it here). The convention was already keyed off the VERSION file's presence; this makes the absence a first-class state instead of a 0.0.0.0 default: - gstack-version-bump classify: new NO_VERSION_FILE state when the resolved version file does not exist (never invents 0.0.0.0, never creates the file; also covers a branch that deletes VERSION to retire the convention). write/repair are unchanged. - ship Step 12: NO_VERSION_FILE dispatch arm - skip Steps 12-13 and the PR/MR title version invariant; plain <type>: <summary> titles; never create a VERSION file. Idempotency note updated for re-runs. - ship Step 13 (CHANGELOG): explicit skip under NO_VERSION_FILE. - ship title invariant: now conditional on Step 12 having produced a version. - land-and-deploy Step 3.4: VERSION drift detection prints n/a and skips when neither the head nor the base has a VERSION file. - Tests: NO_VERSION_FILE for a never-versioned repo (asserts classify stays a pure reader and creates nothing) and for a branch that deleted VERSION while base still has it. bun test on gstack-version-bump, ship-version-sync, gstack-next-version: 59 pass / 0 fail. Generated SKILL.md files regenerated with bun run gen:skill-docs.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(ship): skip version-bump/CHANGELOG/title-rewrite when the repo has no VERSION file
Repos that stamp versions at release/queue time (merge-queue driven repos,
release-please/tag-based flows) have no VERSION file, but /ship today
manufactures one: gstack-version-bump treats a missing file as 0.0.0.0,
classifies FRESH, and
writecreates VERSION at the bumped slot - thenwrites a CHANGELOG release heading and rewrites the PR title to vX.Y.Z.W.
On a queue-managed repo every such PR textually collides with every other
(we hit three pairs of open PRs claiming identical versions in one repo
before tracing it here).
The convention was already keyed off the VERSION file's presence; this
makes the absence a first-class state instead of a 0.0.0.0 default:
resolved version file does not exist (never invents 0.0.0.0, never
creates the file; also covers a branch that deletes VERSION to retire
the convention). write/repair are unchanged.
PR/MR title version invariant; plain :
create a VERSION file. Idempotency note updated for re-runs.
version.
when neither the head nor the base has a VERSION file.
stays a pure reader and creates nothing) and for a branch that deleted
VERSION while base still has it. bun test on gstack-version-bump,
ship-version-sync, gstack-next-version: 59 pass / 0 fail.
Generated SKILL.md files regenerated with bun run gen:skill-docs.