Skip to content

fix: keep ship review retries inside one invocation#2344

Open
yolo-jared wants to merge 6 commits into
garrytan:mainfrom
yolo-jared:fix/ship-internal-review-retry
Open

fix: keep ship review retries inside one invocation#2344
yolo-jared wants to merge 6 commits into
garrytan:mainfrom
yolo-jared:fix/ship-internal-review-retry

Conversation

@yolo-jared

Copy link
Copy Markdown

Summary

  • treat agent-applied pre-landing fixes as an internal ship retry loop instead of requiring a second user invocation
  • generate and install the Codex payload with the GPT overlay, including global ~/.agents discovery
  • migrate source checkouts out of Codex skill-discovery roots to prevent recursive or Claude-source skill loading
  • add regression coverage for same-invocation continuation, GPT generation, global installs, and discovery migration

Verification

  • focused host and generator suites: 484 pass, 0 fail
  • new release-autonomy regressions: 5 pass, 0 fail
  • official non-eval suite under isolated global Git config: 4,440 pass, 2 unrelated failures, 488 skip
    • benchmark auth-remediation wording
    • session-runner observability comment count
    • both failing test/source surfaces are unchanged from origin/main

The non-eval command excludes the repository's LLM and periodic E2E groups through its documented ignore list.

@trunk-io

trunk-io Bot commented Jul 25, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant