feat: add MCP server packaging checks to /review and /ship#579
Open
kalraakshit042 wants to merge 1 commit intogarrytan:mainfrom
Open
feat: add MCP server packaging checks to /review and /ship#579kalraakshit042 wants to merge 1 commit intogarrytan:mainfrom
kalraakshit042 wants to merge 1 commit intogarrytan:mainfrom
Conversation
Adds an "MCP Server Packaging" section to the review checklist and a Glama sync reminder to the ship workflow, based on failure patterns encountered when publishing an MCP server to Glama. review/checklist.md: - Flag package.json exports pointing to src/ instead of dist/ (AUTO-FIX) - Flag ESM imports missing .js extensions under NodeNext resolution (AUTO-FIX) - Flag moduleResolution: "bundler" on standalone Node.js MCP packages (ASK) - Flag missing or malformed glama.json (AUTO-FIX) ship/SKILL.md.tmpl (+ regenerated SKILL.md): - Step 8.25: after PR creation, check for glama.json and remind user to hit Sync in the Glama UI — Docker layer cache won't auto-update
kalraakshit042
force-pushed
the
feat/mcp-packaging-checks
branch
from
4779b75 to
3e9414c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds MCP server packaging checks to `/review` and a Glama sync reminder to `/ship`, based on failure patterns hit when publishing a Node.js MCP server to Glama. Every pattern here caused a real build failure.
`review/checklist.md` — new "MCP Server Packaging" section (Pass 2, Informational)
`ship/SKILL.md.tmpl` — new Step 8.25 (conditional)
After PR creation, checks for `glama.json` and prints a one-line reminder to hit Sync in the Glama UI. Glama caches Docker layers aggressively and won't pick up new commits automatically.
Evidence
All four issues were found on a real production MCP server (https://github.com/kalraakshit042/ai-compass):
Wrong exports path — `package.json` had `"default": "./src/index.ts"`. Glama's Docker build ran the compiled output and got: `Cannot find module '/app/packages/core/src/recommend'`. Fix: change to `"./dist/index.js"`.
Missing `.js` extensions — `tsconfig.json` used `"moduleResolution": "bundler"` which resolved extensionless imports locally. After switching to `NodeNext` for the Docker build: `Cannot find module '/app/packages/core/dist/recommend'`. Fix: add `.js` to every relative import.
Glama Docker cache — After fixing both above and pushing a new commit, Glama still ran the old build from cached layers. No error message — just silently wrong behavior. Fix: hit the "Sync" button in the Glama UI.
Test plan
🤖 Generated with Claude Code