fix: --local install creates missing gstack/ symlink so skills resolve#601
Open
anish749 wants to merge 1 commit intogarrytan:mainfrom
Open
fix: --local install creates missing gstack/ symlink so skills resolve#601anish749 wants to merge 1 commit intogarrytan:mainfrom
anish749 wants to merge 1 commit intogarrytan:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./setup --localis broken. Per-skill symlinks (qa -> gstack/qa) never resolve because there's nogstack/directory inside.claude/skills/.Root cause:
link_claude_skill_dirscreates relative symlinks likeqa -> gstack/qa. For global installs this works because the repo is~/.claude/skills/gstack/. For--local, the skills dir is$(pwd)/.claude/skills/and nothing creates thegstack/entry inside it.Fix: One line. Create
ln -snf "$SOURCE_GSTACK_DIR" "$INSTALL_SKILLS_DIR/gstack"in the--localblock so the symlink chain resolves:.claude/skills/qa -> gstack/qa -> /path/to/repo/qa/SKILL.md.Repro
After fix:
./setup --local --no-prefix ls -la .claude/skills/qa/SKILL.md # resolves correctlyTest plan
rm -rf .claude/skills && ./setup --local --no-prefix— all 28 skills linked,SKILL.mdresolves./setupwithout--local) unchanged —INSTALL_SKILLS_DIRblock not enteredbun testpasses🤖 Generated with Claude Code