Skip to content

docs: add fee currency reconciliation to mainnet roadmap #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garykocsis merged 1 commit into from
Jun 10, 2026
Merged

docs: add fee currency reconciliation to mainnet roadmap #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,16 @@ Both pitfalls were diagnosed from on-chain state and are now documented as manda
- [ ] **`DemoLPRouter.sol` hardening:** Add ERC20 transfer return-value
checks (currently unchecked — acceptable for MockUSDC testnet
demo, not production-ready).
- [ ] **Fee currency reconciliation:** The coverage buffer is denominated
in USDC (token1) but swap fees in an ETH/USDC pool are generated
in either USDC or ETH depending on swap direction. The MVP handles
this by seeding the buffer with real USDC via `seedBuffer()` and
accounting for fee contributions in USDC terms — but ETH-denominated
fees do not automatically create spendable USDC. A mainnet
implementation requires native fee collection plus ETH→USDC
conversion (e.g. via a Uniswap swap or Chainlink price feed) so
that `bufferBalanceStable` always reflects actual payable USDC
reserves rather than notional value.

### Phase 3 — Production

Expand Down
Loading